From: Serge Semin <fancer.lancer@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org,
okaya@codeaurora.org, chenhc@lemote.com,
Sergey.Semin@t-platforms.ru, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method
Date: Wed, 11 Jul 2018 16:52:10 +0300 [thread overview]
Message-ID: <20180711135210.GA18730@mobilestation> (raw)
In-Reply-To: <20180711065631.GA21948@infradead.org>
Hello Christoph,
On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig <hch@infradead.org> wrote:
> > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow
> > + * requests a cachable mapping with CWB attribute enabled.
> > */
> > #define ioremap_cacheable_cow(offset, size) \
> > __ioremap_mode((offset), (size), _CACHE_CACHABLE_COW)
>
> This isn't actually used anywhere in the kernel tree. Please remove it
> as well.
I don't really know whether it is necessary at this point. We discarded the
ioremap_uncached_accelerated() method, since the obvious alternative is now
available: ioremap_wc(). While ioremap_cacheable_cow() hasn't got one.
So if it was up to me, I'd leave it here. Anyway if the subsystem maintainers
think otherwise, I won't refuse to submit a patch with this method removal.
Regards,
-Sergey
next prev parent reply other threads:[~2018-07-11 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 13:57 [PATCH 1/2] mips: mm: Create UCA-based ioremap_wc() method Serge Semin
2018-07-09 13:57 ` [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method Serge Semin
2018-07-10 7:15 ` Mathieu Malaterre
2018-07-10 7:48 ` Serge Semin
2018-07-10 17:59 ` Paul Burton
2018-07-10 19:13 ` Serge Semin
2018-07-10 21:04 ` Paul Burton
2018-07-11 8:27 ` Serge Semin
2018-07-11 6:56 ` Christoph Hellwig
2018-07-11 13:52 ` Serge Semin [this message]
2018-07-17 12:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711135210.GA18730@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=chenhc@lemote.com \
--cc=hch@infradead.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=okaya@codeaurora.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.