From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdHMd-00087n-5k for qemu-devel@nongnu.org; Wed, 11 Jul 2018 11:49:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdHMY-0002pG-5W for qemu-devel@nongnu.org; Wed, 11 Jul 2018 11:49:11 -0400 Date: Wed, 11 Jul 2018 12:48:50 -0300 From: Eduardo Habkost Message-ID: <20180711154850.GT7451@localhost.localdomain> References: <20180705064348.3162-1-kraxel@redhat.com> <20180705064348.3162-3-kraxel@redhat.com> <20180705163501.GN7451@localhost.localdomain> <20180706065342.pggd2qgd4nyv35ys@sirius.home.kraxel.org> <20180709210833.GC7451@localhost.localdomain> <20180709212319.GB22336@localhost.localdomain> <11c6f7d4364062c42df990364bf2c2de@sebastianbauer.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11c6f7d4364062c42df990364bf2c2de@sebastianbauer.info> Subject: Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Bauer Cc: Gerd Hoffmann , Aleksandar Markovic , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Alexander Graf , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno , David Gibson On Tue, Jul 10, 2018 at 12:26:52AM +0200, Sebastian Bauer wrote: > Hi, > > Am 2018-07-09 23:23, schrieb Eduardo Habkost: > > List of machines with default_display==NULL on those > > architectures: > > > > alpha: > > none empty machine > > > > mips: > > mipssim MIPS MIPSsim platform > > none empty machine > > > > ppc*: > > bamboo bamboo > > mpc8544ds mpc8544ds > > none empty machine > > powernv IBM PowerNV (Non-Virtualized) > > ppce500 generic paravirt e500 platform > > ref405ep ref405ep > > sam460ex aCube Sam460ex > > taihu taihu > > virtex-ml507 Xilinx Virtex ML507 reference design > > > > x86_64: > > isapc ISA-only PC > > none empty machine > > xenfv Xen Fully-virtualized PC > > xenpv Xen Para-virtualized PC > > Which of these machines really require the Cirrus? The xen ones look like > that they can deal with std. The isapc is should probably stay at the > Cirrus. > > Also the "none" seems to be a false-positive. I suppose they mean "empty", > i.e., no graphics card at all? "none" looked like a false positive when I first looked, but now I think it's not. Shouldn't it set default_display="none"? > > And at least the ppc ones can be canceled out, they should work with std, > the new default (expect the sam460ex which goes an own route for now). If machines prefer "std", they should set default_display="std" explicitly. > > What is the indented target release for the patch? I'm not convinced this patch is appropriate for 3.0. If we have remaining bugs they should be fixed by setting default_display explicitly on the affected machines. > > If the patch is applied to 3.1 then I think there is enough time to fix > issues caused by the patch. Additionally, a warning could be put in the > ChangeLog for 3.0 that in 3.1 that the default mode will be std unless > machines define an own default. This is should be enough time for people to > complain or to fix things. I don't think we will really make user-visible changes: we can simply work to keep existing behavior, but the difference is that this will be implemented by setting default_display explicitly on all machines. > > If the patch is to be applied to 3.0 then all non-ppc ones need to be > reconsidered. > > The "important" ppc machines have been fixed already. I can do the remaining > if this is wanted. This part worries me: do we have other machines that are broken right now? -- Eduardo