All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/499: add bfoster's alternate reproducer
Date: Thu, 12 Jul 2018 10:47:01 +0800	[thread overview]
Message-ID: <20180712024701.GJ2780@desktop> (raw)
In-Reply-To: <20180711164919.GD5703@magnolia>

On Wed, Jul 11, 2018 at 09:49:19AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Add Brian Foster's alternate reproducer code for this problem so that we
> increase the chances that one of them will reproduce the race problem.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  tests/generic/499 |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/tests/generic/499 b/tests/generic/499
> index 99d6d308..e0b95871 100755
> --- a/tests/generic/499
> +++ b/tests/generic/499
> @@ -33,6 +33,7 @@ _require_xfs_io_command "fzero"
>  
>  rm -f $seqres.full
>  
> +# djwong's reproducer
>  _scratch_mkfs >>$seqres.full 2>&1
>  _scratch_mount
>  
> @@ -52,6 +53,24 @@ victim=$SCRATCH_MNT/a
>  touch $victim
>  $here/ltp/fsx --replay-ops $tmp.fsxops $victim > $tmp.output || cat $tmp.output
>  
> +# bfoster/hch reproducer
> +_scratch_unmount
> +_scratch_mkfs_sized $((1024 * 1024 * 100)) >>$seqres.full 2>&1
> +_scratch_mount

This test uses a different fs setup (_scratch_mkfs_sized), and adds new
sub-test to an existing case, I think it really deserves a new test.

Thanks,
Eryu

> +
> +$XFS_IO_PROG -fc "pwrite 0 100m" -c fsync $SCRATCH_MNT/file >>$seqres.full 2>&1
> +rm -f $SCRATCH_MNT/file
> +
> +cat >> $tmp.fsxops << ENDL
> +truncate 0x0 0x1f0d6 0x380e1
> +write 0x1ad87 0x6c99 0x180d6
> +zero_range 0x14426 0xd3aa 0x21a20 keep_size
> +mapread 0x1f69a 0x2386 0x21a20
> +ENDL
> +
> +touch $victim
> +$here/ltp/fsx --replay-ops $tmp.fsxops $victim > $tmp.output || cat $tmp.output
> +
>  echo "Silence is golden"
>  status=0
>  exit

      parent reply	other threads:[~2018-07-12  2:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11 16:49 [PATCH] generic/499: add bfoster's alternate reproducer Darrick J. Wong
2018-07-11 17:29 ` Christoph Hellwig
2018-07-12  2:47 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712024701.GJ2780@desktop \
    --to=guaneryu@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.