From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()
Date: Thu, 12 Jul 2018 17:09:20 +0900 [thread overview]
Message-ID: <20180712080920.GA17915@jagdpanzerIV> (raw)
In-Reply-To: <20180712075315.vvcebweho635d3le@pathway.suse.cz>
On (07/12/18 09:53), Petr Mladek wrote:
> >
> > True, but at the same time nobody complained that we didn't have those
> > extra WARN_CONSOLE_UNLOCKED()-s. Just saying. Over all I agree that there
> > is probably some value in those extra WARN-s.
>
> I agree that there is some value in the extra WARN's. Also it seems
> that it is useful to disable them for debugging purposes. I do not
> see a better solution. Therefore I am fine with this one.
Good.
> Yes, this extra comment would be appreciated.
Yep.
> If you send v2, please, break also the WARN definition to 80-chars's
> per line ;-)
Yeah, I noticed that too.
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
prev parent reply other threads:[~2018-07-12 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 19:17 [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED() Steven Rostedt
2018-07-11 19:38 ` Hans de Goede
2018-07-12 1:58 ` Sergey Senozhatsky
2018-07-12 3:09 ` Steven Rostedt
2018-07-12 4:25 ` Sergey Senozhatsky
2018-07-12 7:53 ` Petr Mladek
2018-07-12 8:09 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712080920.GA17915@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.