From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v8 0/6] Add ChromeOS EC CEC Support Date: Thu, 12 Jul 2018 13:26:45 +0100 Message-ID: <20180712122645.GE4641@dell> References: <1530716901-30164-1-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1530716901-30164-1-git-send-email-narmstrong@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Neil Armstrong Cc: seanpaul@google.com, fparent@baylibre.com, airlied@linux.ie, sadolfsson@google.com, intel-gfx@lists.freedesktop.org, eballetbo@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, felixe@google.com, hans.verkuil@cisco.com, olof@lixom.net, bleung@google.com, darekm@google.com, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwNCBKdWwgMjAxOCwgTmVpbCBBcm1zdHJvbmcgd3JvdGU6Cgo+IEhpIEFsbCwKPiAK PiBUaGUgbmV3IEdvb2dsZSAiRml6eiIgSW50ZWwtYmFzZWQgQ2hyb21lT1MgZGV2aWNlIGlzIGdh aW5pbmcgQ0VDIHN1cHBvcnQKPiB0aHJvdWdoIGl0J3MgRW1iZWRkZWQgQ29udHJvbGxlciwgdG8g ZW5hYmxlIHRoZSBMaW51eCBDRUMgQ29yZSB0byBjb21tdW5pY2F0ZQo+IHdpdGggaXQgYW5kIGdl dCB0aGUgQ0VDIFBoeXNpY2FsIEFkZHJlc3MgZnJvbSB0aGUgY29ycmVjdCBIRE1JIENvbm5lY3Rv ciwgdGhlCj4gZm9sbG93aW5nIG11c3QgYmUgYWRkZWQvY2hhbmdlZDoKPiAtIEFkZCB0aGUgQ0VD IHN1Yi1kZXZpY2UgcmVnaXN0cmF0aW9uIGluIHRoZSBDaHJvbWVPUyBFQyBNRkQgRHJpdmVyCj4g LSBBZGQgdGhlIENFQyByZWxhdGVkIGNvbW1hbmRzIGFuZCBldmVudHMgZGVmaW5pdGlvbnMgaW50 byB0aGUgRUMgTUZEIGRyaXZlcgo+IC0gQWRkIGEgd2F5IHRvIGdldCBhIENFQyBub3RpZmllciB3 aXRoIGl0J3MgKG9wdGlvbmFsKSBjb25uZWN0b3IgbmFtZQo+IC0gQWRkIHRoZSBDRUMgbm90aWZp ZXIgdG8gdGhlIGk5MTUgSERNSSBkcml2ZXIKPiAtIEFkZCB0aGUgcHJvcGVyIENocm9tZU9TIEVD IENFQyBEcml2ZXIKPiAKPiBUaGUgQ0VDIG5vdGlmaWVyIHdpdGggdGhlIGNvbm5lY3RvciBuYW1l IGlzIHRoZSB0cmlja3kgcG9pbnQsIHNpbmNlIGV2ZW4gb24KPiBEZXZpY2UtVHJlZSBwbGF0Zm9y bXMsIHRoZXJlIGlzIG5vIHdheSB0byBkaXN0aW5ndWlzaCBiZXR3ZWVuIG11bHRpcGxlIEhETUkK PiBjb25uZWN0b3JzIGZyb20gdGhlIHNhbWUgRFJNIGRyaXZlci4gVGhlIHNvbHV0aW9uIEkgaW1w bGVtZW50ZWQgaXMgcHJldHR5Cj4gc2ltcGxlIGFuZCBvbmx5IGFkZHMgYW4gb3B0aW9uYWwgY29u bmVjdG9yIG5hbWUgdG8gZXZlbnR1YWxseSBkaXN0aW5ndWlzaAo+IGFuIEhETUkgY29ubmVjdG9y IG5vdGlmaWVyIGZyb20gYW5vdGhlciBpZiB0aGV5IHNoYXJlIHRoZSBzYW1lIGRldmljZS4KPiAK PiBGZWVsIGZyZWUgdG8gY29tbWVudCB0aGlzIHBhdGNoc2V0ICEKPiAKPiBDaGFuZ2VzIHNpbmNl IHY3Ogo+IC0gcmViYXNlZCBvbiB2NC4xOC1yYzEKPiAtIEZpeGVkIHdoaXRlc3BhY2UgaXNzdWVz IG9uIHBhdGNoIDMKPiAtIEFkZGVkIExlZSdzIHRhZ3MKPiAKPiBDaGFuZ2VzIHNpbmNlIHY2Ogo+ IC0gQWRkZWQgc3RhYmxlIGlkZW50aWZpZXIgY29tbWVudCBpbiBpbnRlbF9kaXNwbGF5LmgKPiAt IFJlbmFtZWQgdG8gY2VjX25vdGlmaWVyIGluIGludGVsX2hkbWkuYy9pbnRlbF9kcnYuaAo+IC0g QWRkZWQgQWNrZWQtYnkvUmV2aWV3ZWQtQnkgdGFncwo+IAo+IENoYW5nZXMgc2luY2UgdjU6Cj4g IC0gU21hbGwgZml4dXBzIG9uIGluY2x1ZGUvbGludXgvbWZkL2Nyb3NfZWNfY29tbWFuZHMuaAo+ ICAtIEZpeGVkIG9uIGNyb3MtZWMtY2VjIGRyaXZlciBhY2NvcmRpbmdseQo+ICAtIEFkZGVkIFJl dmlld2VkLUJ5IHRhZ3MKPiAKPiBDaGFuZ2VzIHNpbmNlIHY0Ogo+ICAtIFNwbGl0IHBhdGNoIDMg dG8gbW92ZSB0aGUgbWticCBldmVudCBzaXplIGNoYW5nZSBpbnRvIGEgc2VwYXJhdGUgcGF0Y2gK PiAKPiBDaGFuZ2VzIHNpbmNlIHYzIChpbmNvcnJlY3RseSByZXBvcnRlZCBhcyB2Mik6Cj4gIC0g UmVuYW1lZCAiQ2hyb21lIE9TIiB0byAiQ2hyb21lT1MiCj4gIC0gVXBkYXRlZCBjcm9zX2VjX2Nv bW1hbmRzLmggbmV3IHN0cnVjdHMgZGVmaW5pdGlvbnMgdG8ga2VybmVsIGRvYyBmb3JtYXQKPiAg LSBBZGRlZCBSZXZpZXdlZC1CeSB0YWdzCj4gCj4gQ2hhbmdlcyBzaW5jZSB2MjoKPiAgLSBBZGQg aTkxNSBwb3J0X2lkZW50aWZpZXIoKSBhbmQgdXNlIHRoaXMgc3RhYmxlIG5hbWUgYXMgY2VjX25v dGlmaWVyIGNvbm4gbmFtZQo+ICAtIEZpeGVkIGFuZCBjbGVhbmVkIHVwIHRoZSBDRUMgY29tbWFu ZHMgYW5kIGV2ZW50cyBoYW5kbGluZwo+ICAtIFJlYmFzZWQgdGhlIENFQyBzdWItZGV2aWNlIHJl Z2lzdHJhdGlvbiBvbiB0b3Agb2YgRW5yaWMncyBzZXJpZQo+ICAtIEZpeGVkIGNvbW1lbnRzIHR5 cG8gb24gY2VjIGRyaXZlcgo+ICAtIFByb3RlY3RlZCB0aGUgRE1JIG1hdGNoIG9ubHkgd2l0aCBQ Q0kgYW5kIERNSSBLY29uZmlncwo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4gIC0gQWRkZWQgY2Vj X25vdGlmaWVyX3B1dCB0byBpbnRlbF9oZG1pCj4gIC0gRml4ZWQgYWxsIHNtYWxsIHJlcG9ydGVk IGlzc3VlcyBvbiB0aGUgRUMgQ0VDIGRyaXZlcgo+ICAtIE1vdmVkIHRoZSBjZWNfbm90aWZpZXJf Z2V0IG91dCBvZiB0aGUgI2lmIC4uICNlbHNlIC4uICNlbmRpZgo+IAo+IENoYW5nZXMgc2luY2Ug UkZDOgo+ICAtIE1vdmVkIENFQyBzdWItZGV2aWNlIHJlZ2lzdHJhdGlvbiBhZnRlciBDRUMgY29t bWFuZHMgYW5kIGV2ZW50cyBkZWZpbml0aW9ucyBwYXRjaAo+ICAtIFJlbW92ZWQgZ2V0X25vdGlm aWVyX2dldF9ieW5hbWUKPiAgLSBBZGRlZCBDRUNfQ09SRSBzZWxlY3QgaW50byBpOTE1IEtjb25m aWcKPiAgLSBSZW1vdmVkIENFQyBkcml2ZXIgZmFsbGJhY2sgaWYgbm90aWZpZXIgaXMgbm90IGNv bmZpZ3VyZWQgb24gSFcsIGFkZGVkIGV4cGxpY2l0IHdhcm4KPiAgLSBGaXhlZCBDRUMgY29yZSBy ZXR1cm4gdHlwZSBvbiBlcnJvcgo+ICAtIE1vdmVkIHRvIGNyb3MtZWMtY2VjIG1lZGlhIHBsYXRm b3JtIGRpcmVjdG9yeQo+ICAtIFVzZSBidXNfZmluZF9kZXZpY2UoKSB0byBmaW5kIHRoZSBwY2kg aTkxNSBkZXZpY2UgaW5zdGVhZCBvZiBnZXRfbm90aWZpZXJfZ2V0X2J5bmFtZSgpCj4gIC0gRml4 IExvZ2ljYWwgQWRkcmVzcyBzZXR1cAo+ICAtIEFkZGVkIGNvbW1lbnQgYWJvdXQgSFcgc3VwcG9y dAo+ICAtIFJlbW92ZWQgbWVtc2V0IG9mIG1zZyBzdHJ1Y3R1cmVzCj4gCj4gTmVpbCBBcm1zdHJv bmcgKDYpOgo+ICAgbWVkaWE6IGNlYy1ub3RpZmllcjogR2V0IG5vdGlmaWVyIGJ5IGRldmljZSBh bmQgY29ubmVjdG9yIG5hbWUKPiAgIGRybS9pOTE1OiBoZG1pOiBhZGQgQ0VDIG5vdGlmaWVyIHRv IGludGVsX2hkbWkKPiAgIG1mZDogY3Jvcy1lYzogSW5jcmVhc2UgbWF4aW11bSBta2JwIGV2ZW50 IHNpemUKPiAgIG1mZDogY3Jvcy1lYzogSW50cm9kdWNlIENFQyBjb21tYW5kcyBhbmQgZXZlbnRz IGRlZmluaXRpb25zLgo+ICAgbWZkOiBjcm9zX2VjX2RldjogQWRkIENFQyBzdWItZGV2aWNlIHJl Z2lzdHJhdGlvbgo+ICAgbWVkaWE6IHBsYXRmb3JtOiBBZGQgQ2hyb21lT1MgRUMgQ0VDIGRyaXZl cgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9LY29uZmlnICAgICAgICAgICAgICAgICAgICAg fCAgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmggICAgICAgICAg ICAgfCAgMjQgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgICAgICAg ICAgICAgIHwgICAyICsKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jICAgICAg ICAgICAgICAgIHwgIDEzICsKPiAgZHJpdmVycy9tZWRpYS9jZWMvY2VjLW5vdGlmaWVyLmMgICAg ICAgICAgICAgICAgIHwgIDExICstCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vS2NvbmZpZyAg ICAgICAgICAgICAgICAgICB8ICAxMSArCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vTWFrZWZp bGUgICAgICAgICAgICAgICAgICB8ICAgMiArCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vY3Jv cy1lYy1jZWMvTWFrZWZpbGUgICAgICB8ICAgMSArCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0v Y3Jvcy1lYy1jZWMvY3Jvcy1lYy1jZWMuYyB8IDM0NyArKysrKysrKysrKysrKysrKysrKysrKwo+ ICBkcml2ZXJzL21mZC9jcm9zX2VjX2Rldi5jICAgICAgICAgICAgICAgICAgICAgICAgfCAgMTYg KysKPiAgZHJpdmVycy9wbGF0Zm9ybS9jaHJvbWUvY3Jvc19lY19wcm90by5jICAgICAgICAgIHwg IDQwICsrLQo+ICBpbmNsdWRlL2xpbnV4L21mZC9jcm9zX2VjLmggICAgICAgICAgICAgICAgICAg ICAgfCAgIDIgKy0KPiAgaW5jbHVkZS9saW51eC9tZmQvY3Jvc19lY19jb21tYW5kcy5oICAgICAg ICAgICAgIHwgIDk3ICsrKysrKysKPiAgaW5jbHVkZS9tZWRpYS9jZWMtbm90aWZpZXIuaCAgICAg ICAgICAgICAgICAgICAgIHwgIDI3ICstCj4gIDE0IGZpbGVzIGNoYW5nZWQsIDU3OCBpbnNlcnRp b25zKCspLCAxNiBkZWxldGlvbnMoLSkKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWVk aWEvcGxhdGZvcm0vY3Jvcy1lYy1jZWMvTWFrZWZpbGUKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRy aXZlcnMvbWVkaWEvcGxhdGZvcm0vY3Jvcy1lYy1jZWMvY3Jvcy1lYy1jZWMuYwoKSG93IHdvdWxk IHlvdSBsaWtlIHRvIGhhbmRsZSB0aGlzIHNldD8KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10K TGluYXJvIFNlcnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNl IHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIg fCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:38103 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbeGLMgK (ORCPT ); Thu, 12 Jul 2018 08:36:10 -0400 Received: by mail-wm0-f65.google.com with SMTP id 69-v6so5806501wmf.3 for ; Thu, 12 Jul 2018 05:26:48 -0700 (PDT) Date: Thu, 12 Jul 2018 13:26:45 +0100 From: Lee Jones To: Neil Armstrong Cc: airlied@linux.ie, hans.verkuil@cisco.com, olof@lixom.net, seanpaul@google.com, sadolfsson@google.com, felixe@google.com, bleung@google.com, darekm@google.com, marcheu@chromium.org, fparent@baylibre.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, eballetbo@gmail.com Subject: Re: [PATCH v8 0/6] Add ChromeOS EC CEC Support Message-ID: <20180712122645.GE4641@dell> References: <1530716901-30164-1-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1530716901-30164-1-git-send-email-narmstrong@baylibre.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, 04 Jul 2018, Neil Armstrong wrote: > Hi All, > > The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support > through it's Embedded Controller, to enable the Linux CEC Core to communicate > with it and get the CEC Physical Address from the correct HDMI Connector, the > following must be added/changed: > - Add the CEC sub-device registration in the ChromeOS EC MFD Driver > - Add the CEC related commands and events definitions into the EC MFD driver > - Add a way to get a CEC notifier with it's (optional) connector name > - Add the CEC notifier to the i915 HDMI driver > - Add the proper ChromeOS EC CEC Driver > > The CEC notifier with the connector name is the tricky point, since even on > Device-Tree platforms, there is no way to distinguish between multiple HDMI > connectors from the same DRM driver. The solution I implemented is pretty > simple and only adds an optional connector name to eventually distinguish > an HDMI connector notifier from another if they share the same device. > > Feel free to comment this patchset ! > > Changes since v7: > - rebased on v4.18-rc1 > - Fixed whitespace issues on patch 3 > - Added Lee's tags > > Changes since v6: > - Added stable identifier comment in intel_display.h > - Renamed to cec_notifier in intel_hdmi.c/intel_drv.h > - Added Acked-by/Reviewed-By tags > > Changes since v5: > - Small fixups on include/linux/mfd/cros_ec_commands.h > - Fixed on cros-ec-cec driver accordingly > - Added Reviewed-By tags > > Changes since v4: > - Split patch 3 to move the mkbp event size change into a separate patch > > Changes since v3 (incorrectly reported as v2): > - Renamed "Chrome OS" to "ChromeOS" > - Updated cros_ec_commands.h new structs definitions to kernel doc format > - Added Reviewed-By tags > > Changes since v2: > - Add i915 port_identifier() and use this stable name as cec_notifier conn name > - Fixed and cleaned up the CEC commands and events handling > - Rebased the CEC sub-device registration on top of Enric's serie > - Fixed comments typo on cec driver > - Protected the DMI match only with PCI and DMI Kconfigs > > Changes since v1: > - Added cec_notifier_put to intel_hdmi > - Fixed all small reported issues on the EC CEC driver > - Moved the cec_notifier_get out of the #if .. #else .. #endif > > Changes since RFC: > - Moved CEC sub-device registration after CEC commands and events definitions patch > - Removed get_notifier_get_byname > - Added CEC_CORE select into i915 Kconfig > - Removed CEC driver fallback if notifier is not configured on HW, added explicit warn > - Fixed CEC core return type on error > - Moved to cros-ec-cec media platform directory > - Use bus_find_device() to find the pci i915 device instead of get_notifier_get_byname() > - Fix Logical Address setup > - Added comment about HW support > - Removed memset of msg structures > > Neil Armstrong (6): > media: cec-notifier: Get notifier by device and connector name > drm/i915: hdmi: add CEC notifier to intel_hdmi > mfd: cros-ec: Increase maximum mkbp event size > mfd: cros-ec: Introduce CEC commands and events definitions. > mfd: cros_ec_dev: Add CEC sub-device registration > media: platform: Add ChromeOS EC CEC driver > > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/i915/intel_display.h | 24 ++ > drivers/gpu/drm/i915/intel_drv.h | 2 + > drivers/gpu/drm/i915/intel_hdmi.c | 13 + > drivers/media/cec/cec-notifier.c | 11 +- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile | 2 + > drivers/media/platform/cros-ec-cec/Makefile | 1 + > drivers/media/platform/cros-ec-cec/cros-ec-cec.c | 347 +++++++++++++++++++++++ > drivers/mfd/cros_ec_dev.c | 16 ++ > drivers/platform/chrome/cros_ec_proto.c | 40 ++- > include/linux/mfd/cros_ec.h | 2 +- > include/linux/mfd/cros_ec_commands.h | 97 +++++++ > include/media/cec-notifier.h | 27 +- > 14 files changed, 578 insertions(+), 16 deletions(-) > create mode 100644 drivers/media/platform/cros-ec-cec/Makefile > create mode 100644 drivers/media/platform/cros-ec-cec/cros-ec-cec.c How would you like to handle this set? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog