From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 12 Jul 2018 13:29:06 +0100 Subject: [PATCH v2 2/5] mfd: axp20x: Add self-working mode support for AXP806 In-Reply-To: <20180705031106.344-3-wens@csie.org> References: <20180705031106.344-1-wens@csie.org> <20180705031106.344-3-wens@csie.org> Message-ID: <20180712122906.GG4641@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 05 Jul 2018, Chen-Yu Tsai wrote: > The AXP806 can operate in a standalone "self-working" mode, in which it > is also responsible for power control of the overall system. This mode > is similar to the master mode, but the EN/PWRON pin functions as a power > button, instead of a level-triggered enable switch. > > This patch adds code checking for the new "x-powers,self-working-mode" > property, and a separate mfd_cell list that includes the power button > (PEK) sub-device. > > Reviewed-by: Icenowy Zheng > Tested-by: Icenowy Zheng > Signed-off-by: Chen-Yu Tsai > --- > drivers/mfd/axp20x.c | 30 +++++++++++++++++++++++++++--- > 1 file changed, 27 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 9a2ef3d9b8f8..1988881529a9 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -221,6 +221,11 @@ static const struct resource axp803_pek_resources[] = { > DEFINE_RES_IRQ_NAMED(AXP803_IRQ_PEK_FAL_EDGE, "PEK_DBF"), > }; > > +static const struct resource axp806_pek_resources[] = { > + DEFINE_RES_IRQ_NAMED(AXP806_IRQ_POK_RISE, "PEK_DBR"), > + DEFINE_RES_IRQ_NAMED(AXP806_IRQ_POK_FALL, "PEK_DBF"), > +}; > + > static const struct resource axp809_pek_resources[] = { > DEFINE_RES_IRQ_NAMED(AXP809_IRQ_PEK_RIS_EDGE, "PEK_DBR"), > DEFINE_RES_IRQ_NAMED(AXP809_IRQ_PEK_FAL_EDGE, "PEK_DBF"), > @@ -730,6 +735,17 @@ static const struct mfd_cell axp803_cells[] = { > { .name = "axp20x-regulator" }, > }; > > +static const struct mfd_cell axp806_self_working_cells[] = { > + { > + .name = "axp221-pek", > + .num_resources = ARRAY_SIZE(axp806_pek_resources), > + .resources = axp806_pek_resources, > + }, > + { > + .name = "axp20x-regulator", > + }, Nit: this should be on a single line, like it is above. Once fixed, please re-submit with my: For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [???] Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 2/5] mfd: axp20x: Add self-working mode support for AXP806 Date: Thu, 12 Jul 2018 13:29:06 +0100 Message-ID: <20180712122906.GG4641@dell> References: <20180705031106.344-1-wens@csie.org> <20180705031106.344-3-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180705031106.344-3-wens@csie.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Chen-Yu Tsai Cc: Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Icenowy Zheng List-Id: devicetree@vger.kernel.org T24gVGh1LCAwNSBKdWwgMjAxOCwgQ2hlbi1ZdSBUc2FpIHdyb3RlOgoKPiBUaGUgQVhQODA2IGNh biBvcGVyYXRlIGluIGEgc3RhbmRhbG9uZSAic2VsZi13b3JraW5nIiBtb2RlLCBpbiB3aGljaCBp dAo+IGlzIGFsc28gcmVzcG9uc2libGUgZm9yIHBvd2VyIGNvbnRyb2wgb2YgdGhlIG92ZXJhbGwg c3lzdGVtLiBUaGlzIG1vZGUKPiBpcyBzaW1pbGFyIHRvIHRoZSBtYXN0ZXIgbW9kZSwgYnV0IHRo ZSBFTi9QV1JPTiBwaW4gZnVuY3Rpb25zIGFzIGEgcG93ZXIKPiBidXR0b24sIGluc3RlYWQgb2Yg YSBsZXZlbC10cmlnZ2VyZWQgZW5hYmxlIHN3aXRjaC4KPiAKPiBUaGlzIHBhdGNoIGFkZHMgY29k ZSBjaGVja2luZyBmb3IgdGhlIG5ldyAieC1wb3dlcnMsc2VsZi13b3JraW5nLW1vZGUiCj4gcHJv cGVydHksIGFuZCBhIHNlcGFyYXRlIG1mZF9jZWxsIGxpc3QgdGhhdCBpbmNsdWRlcyB0aGUgcG93 ZXIgYnV0dG9uCj4gKFBFSykgc3ViLWRldmljZS4KPiAKPiBSZXZpZXdlZC1ieTogSWNlbm93eSBa aGVuZyA8aWNlbm93eUBhb3NjLmlvPgo+IFRlc3RlZC1ieTogSWNlbm93eSBaaGVuZyA8aWNlbm93 eUBhb3NjLmlvPgo+IFNpZ25lZC1vZmYtYnk6IENoZW4tWXUgVHNhaSA8d2Vuc0Bjc2llLm9yZz4K PiAtLS0KPiAgZHJpdmVycy9tZmQvYXhwMjB4LmMgfCAzMCArKysrKysrKysrKysrKysrKysrKysr KysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL2F4cDIweC5jIGIvZHJpdmVycy9tZmQv YXhwMjB4LmMKPiBpbmRleCA5YTJlZjNkOWI4ZjguLjE5ODg4ODE1MjlhOSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL21mZC9heHAyMHguYwo+ICsrKyBiL2RyaXZlcnMvbWZkL2F4cDIweC5jCj4gQEAg LTIyMSw2ICsyMjEsMTEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCByZXNvdXJjZSBheHA4MDNfcGVr X3Jlc291cmNlc1tdID0gewo+ICAJREVGSU5FX1JFU19JUlFfTkFNRUQoQVhQODAzX0lSUV9QRUtf RkFMX0VER0UsICJQRUtfREJGIiksCj4gIH07Cj4gIAo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJl c291cmNlIGF4cDgwNl9wZWtfcmVzb3VyY2VzW10gPSB7Cj4gKwlERUZJTkVfUkVTX0lSUV9OQU1F RChBWFA4MDZfSVJRX1BPS19SSVNFLCAiUEVLX0RCUiIpLAo+ICsJREVGSU5FX1JFU19JUlFfTkFN RUQoQVhQODA2X0lSUV9QT0tfRkFMTCwgIlBFS19EQkYiKSwKPiArfTsKPiArCj4gIHN0YXRpYyBj b25zdCBzdHJ1Y3QgcmVzb3VyY2UgYXhwODA5X3Bla19yZXNvdXJjZXNbXSA9IHsKPiAgCURFRklO RV9SRVNfSVJRX05BTUVEKEFYUDgwOV9JUlFfUEVLX1JJU19FREdFLCAiUEVLX0RCUiIpLAo+ICAJ REVGSU5FX1JFU19JUlFfTkFNRUQoQVhQODA5X0lSUV9QRUtfRkFMX0VER0UsICJQRUtfREJGIiks Cj4gQEAgLTczMCw2ICs3MzUsMTcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRfY2VsbCBheHA4 MDNfY2VsbHNbXSA9IHsKPiAgCXsJLm5hbWUJCQk9ICJheHAyMHgtcmVndWxhdG9yIiB9LAo+ICB9 Owo+ICAKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRfY2VsbCBheHA4MDZfc2VsZl93b3JraW5n X2NlbGxzW10gPSB7Cj4gKwl7Cj4gKwkJLm5hbWUJCQk9ICJheHAyMjEtcGVrIiwKPiArCQkubnVt X3Jlc291cmNlcwkJPSBBUlJBWV9TSVpFKGF4cDgwNl9wZWtfcmVzb3VyY2VzKSwKPiArCQkucmVz b3VyY2VzCQk9IGF4cDgwNl9wZWtfcmVzb3VyY2VzLAo+ICsJfSwKPiArCXsKPiArCQkubmFtZQkJ CT0gImF4cDIweC1yZWd1bGF0b3IiLAo+ICsJfSwKCk5pdDogdGhpcyBzaG91bGQgYmUgb24gYSBz aW5nbGUgbGluZSwgbGlrZSBpdCBpcyBhYm92ZS4KCk9uY2UgZml4ZWQsIHBsZWFzZSByZS1zdWJt aXQgd2l0aCBteToKCkZvciBteSBvd24gcmVmZXJlbmNlOgogIEFja2VkLWZvci1NRkQtYnk6IExl ZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9d CkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJj ZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVy IHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=