Re: [igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use
Date: Thu, 12 Jul 2018 16:00:31 +0300	[thread overview]
Message-ID: <20180712130031.GA5565@intel.com> (raw)
In-Reply-To: <20180712101245.20683-1-chris@chris-wilson.co.uk>

On Thu, Jul 12, 2018 at 11:12:45AM +0100, Chris Wilson wrote:
> We use the GPU to convert between tiling formats, indirectly via the
> call to igt_create_pattern_fb. So before we try and execute commands on
> the GPU, we should check that the GPU is available.

Should this one be in the actualy spot in igt_fb.c where we do
the gem stuff? I could imagine other drivers might want to add
their own mechanisms there.

Or we add some kind of igt_require_fb() to indicate igt_fb
will be used?

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/kms_flip_tiling.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> index beeb111be..77ed8a68f 100644
> --- a/tests/kms_flip_tiling.c
> +++ b/tests/kms_flip_tiling.c
> @@ -147,6 +147,7 @@ igt_main
>  	igt_fixture {
>  		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
>  		data.gen = intel_gen(intel_get_drm_devid(data.drm_fd));
> +		igt_require_gem(data.drm_fd);
>  
>  		kmstest_set_vt_graphics_mode();
>  
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev