From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 2/2] net: phy: add phy_speed_down and
 phy_speed_up
Date: Thu, 12 Jul 2018 21:09:45 +0200
Message-ID: <20180712190945.GC10740@lunn.ch>
References: <0d031081-4a7f-ddde-87c0-2c1c6be543c3@gmail.com>
 <407ed2cd-db27-f179-8b98-0d1e61513e07@gmail.com>
 <20180711205518.GJ21430@lunn.ch>
 <7dfcb4d5-2a0c-9244-53e4-564014b16b58@gmail.com>
 <28ea392b-6d3a-0efe-a0ed-ebe82fe14099@gmail.com>
 <a9a668e3-772b-61bf-85c2-801dc46f8ecf@gmail.com>
 <0354bc0f-4bac-9715-e183-1a74b9cc6f1b@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:60758 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726480AbeGLTUk (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 12 Jul 2018 15:20:40 -0400
Content-Disposition: inline
In-Reply-To: <0354bc0f-4bac-9715-e183-1a74b9cc6f1b@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Like r8169 also tg3 driver doesn't wait for the speed-down-renegotiation
> to finish. Therefore, even though I share Andrew's concerns, there seem
> to be chips where it's safe to not wait for the renegotiation to finish
> (e.g. because device is in PCI D3 already and can't generate an interrupt).
> Having said that I'd keep the sync parameter for phy_speed_down so that
> the driver can decide.

Hi Heiner

Please put a big fat comment about the dangers of sync=false in the
function header. We want people to known it is dangerous by default,
and should only be used in special conditions, when it is known to be
safe.
	Andrew