All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226
Date: Thu, 12 Jul 2018 18:12:08 -0400	[thread overview]
Message-ID: <20180712221208.3732-1-jsnow@redhat.com> (raw)

This test doesn't actually care about the format anyway, it just
supports "all formats" as a convenience. LUKS however does not use a
simple image filename which confuses this iotest.

We can simply remove the LUKS "support" and be happier for it.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/qemu-iotests/226 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226
index 460aea2fc9..ebfaf62e53 100755
--- a/tests/qemu-iotests/226
+++ b/tests/qemu-iotests/226
@@ -40,7 +40,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 . ./common.pattern
 
 # Generic format, but tests file-protocol specific error handling
+# LUKS does not use a simple filename; this test doesn't use the format anyway.
 _supported_fmt generic
+_unsupported_fmt luks
 _supported_proto file
 _supported_os Linux
 
-- 
2.14.4

             reply	other threads:[~2018-07-12 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 22:12 John Snow [this message]
2018-07-13  7:09 ` [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226 Kevin Wolf
2018-07-13 17:06   ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712221208.3732-1-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.