All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH] drm/i915/psr: Remove useless function calls.
Date: Thu, 12 Jul 2018 23:40:28 -0700	[thread overview]
Message-ID: <20180713064027.GC2459@intel.com> (raw)
In-Reply-To: <798d8ed4c1a50285626598fd5b7edc4056c4b33c.camel@intel.com>

On Wed, Jul 11, 2018 at 10:04:00PM +0000, Souza, Jose wrote:
> On Wed, 2018-07-11 at 15:00 -0700, Rodrigo Vivi wrote:
> > PSR is no longer supported on VLV/CHV so this is just dead code.
> > 
> 
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

pushed to dinq, thanks

> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c
> > b/drivers/gpu/drm/i915/intel_dp.c
> > index 5be07e1d816d..7d40bfcb1bbb 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct
> > intel_encoder *encoder,
> >  			   const struct intel_crtc_state
> > *old_crtc_state,
> >  			   const struct drm_connector_state
> > *old_conn_state)
> >  {
> > -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> > -
> > -	intel_psr_disable(intel_dp, old_crtc_state);
> > -
> >  	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
> >  }
> >  
> > @@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder
> > *encoder,
> >  			  const struct intel_crtc_state
> > *pipe_config,
> >  			  const struct drm_connector_state
> > *conn_state)
> >  {
> > -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> > -
> >  	intel_edp_backlight_on(pipe_config, conn_state);
> > -	intel_psr_enable(intel_dp, pipe_config);
> >  }
> >  
> >  static void g4x_pre_enable_dp(struct intel_encoder *encoder,
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-07-13  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11 22:00 [PATCH] drm/i915/psr: Remove useless function calls Rodrigo Vivi
2018-07-11 22:04 ` Souza, Jose
2018-07-13  6:40   ` Rodrigo Vivi [this message]
2018-07-11 23:05 ` ✓ Fi.CI.BAT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713064027.GC2459@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.