All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: David Ahern <dsahern@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	netdev@vger.kernel.org,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Jiri Pirko <jiri@mellanox.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH iproute2-next 0/9] TC more JSON support
Date: Fri, 13 Jul 2018 14:29:42 -0700	[thread overview]
Message-ID: <20180713142942.49d24264@cakuba.lan> (raw)
In-Reply-To: <9ad5c235-8c66-4a62-0517-af4ae6bdddac@gmail.com>

On Fri, 13 Jul 2018 16:48:28 -0400, David Ahern wrote:
> On 7/9/18 3:48 PM, Stephen Hemminger wrote:
> > From: Stephen Hemminger <sthemmin@microsoft.com>
> > 
> > Update core of TC command and library to do more JSON.
> > Most of this patch set is about getting tc utility functions
> > to be more friendly to the json_print infrastructure.
> > 
> > Stephen Hemminger (9):
> >   tc: use JSON in error handling
> >   tc: use const char in util
> >   tc: convert stats print to json
> >   tc/cbq: use sprint_rate
> >   tc/util: remove print_rate
> >   tc/util: remove unused print_size
> >   tc/util: remove unused print_time
> >   tc/util: add print helpers for JSON
> >   tc/sfq: add json support
> > 
> >  tc/q_cbq.c   | 15 ++++-----
> >  tc/q_sfq.c   | 65 +++++++++++++++++++++---------------
> >  tc/tc.c      | 19 ++++++-----
> >  tc/tc_util.c | 94 +++++++++++++++++++++++++++-------------------------
> >  tc/tc_util.h | 11 +++---
> >  5 files changed, 109 insertions(+), 95 deletions(-)
> >   
> 
> I'd prefer some tc folks to take a look at the json output and verify
> everything is good.
> 
> Jamal, Jiri, Jakub, Cong, others?
> 
> There is a second set with 30 patches as well.

AFAIK the 31 patches supersede this set?  I only have tests that use
JSON for MQ and RED qdiscs, and those work fine with the v2 applied!

  reply	other threads:[~2018-07-13 21:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 19:48 [PATCH iproute2-next 0/9] TC more JSON support Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 1/9] tc: use JSON in error handling Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 2/9] tc: use const char in util Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 3/9] tc: convert stats print to json Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 4/9] tc/cbq: use sprint_rate Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 5/9] tc/util: remove print_rate Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 6/9] tc/util: remove unused print_size Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 7/9] tc/util: remove unused print_time Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 8/9] tc/util: add print helpers for JSON Stephen Hemminger
2018-07-09 19:48 ` [PATCH iproute2-next 9/9] tc/sfq: add json support Stephen Hemminger
2018-07-13 20:48 ` [PATCH iproute2-next 0/9] TC more JSON support David Ahern
2018-07-13 21:29   ` Jakub Kicinski [this message]
2018-07-13 22:22     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713142942.49d24264@cakuba.lan \
    --to=jakub.kicinski@netronome.com \
    --cc=dsahern@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.