From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:62150 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729681AbeGMQGr (ORCPT ); Fri, 13 Jul 2018 12:06:47 -0400 Date: Fri, 13 Jul 2018 09:51:16 -0600 From: Keith Busch To: Greg KH Cc: Scott Bauer , stable@vger.kernel.org, Jon Derrick Subject: Re: [BACKPORT PATCH] nvme-pci: Remap CMB SQ entries on every controller reset Message-ID: <20180713155116.GA19046@localhost.localdomain> References: <20180712212717.15318-1-scott.bauer@intel.com> <20180713120104.GA20397@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180713120104.GA20397@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jul 13, 2018 at 02:01:04PM +0200, Greg KH wrote: > On Thu, Jul 12, 2018 at 03:27:17PM -0600, Scott Bauer wrote: > > Commit 815c6704bf9f1c59f3a6be380a4032b9c57b12f1 upstream. > > > > The controller memory buffer is remapped into a kernel address on each > > reset, but the driver was setting the submission queue base address > > only on the very first queue creation. The remapped address is likely to > > change after a reset, so accessing the old address will hit a kernel bug. > > > > This patch fixes that by setting the queue's CMB base address each time > > the queue is created. > > > > Fixes: f63572dff1421 ("nvme: unmap CMB and remove sysfs file in reset path") > > Reported-by: Christian Black > > Cc: Jon Derrick > > Signed-off-by: Keith Busch > > Reviewed-by: Christoph Hellwig > > Signed-off-by: Scott Bauer > > Reviewed-by: Jon Derrick > > --- > > drivers/nvme/host/pci.c | 27 ++++++++++++++++----------- > > 1 file changed, 16 insertions(+), 11 deletions(-) > > "backport" to where? What kernel tree(s) do you want this applied to? > > I need a hint please... Sorry about that. 4.9 and 4.14 are the applicable targets.