From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO Date: Fri, 13 Jul 2018 19:07:19 +0300 Message-ID: <20180713160719.GM5565@intel.com> References: <20180713154212.17036-1-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60C5E6F2EE for ; Fri, 13 Jul 2018 16:07:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180713154212.17036-1-lucas.demarchi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, JaniNikulajani.nikula@linux.intel.com, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdWwgMTMsIDIwMTggYXQgMDg6NDI6MTFBTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IEluc3RlYWQgb2YgZGVmaW5pbmcgYWxsIHJlZ2lzdGVycyB0d2ljZSwgZGVmaW5l IGp1c3QgYSBQQ0hfR1BJT19CQVNFCj4gdGhhdCBoYXMgdGhlIHNhbWUgYWRkcmVzcyBhcyBQQ0hf R1BJT19BIGFuZCB1c2UgdGhhdCB0byBjYWxjdWxhdGUgYWxsCj4gdGhlIG90aGVycy4gVGhpcyBh bHNvIGJyaW5ncyBWTFYgYW5kICFIQVNfR01DSF9ESVNQTEFZIGluIGxpbmUsIGRvaW5nCj4gdGhl IHNhbWUgdGhpbmcuCj4gCj4gdjI6IEZpeCBHTUJVUyByZWdpc3RlcnMgdG8gYmUgcmVsYXRpdmUg dG8gZ3BpbyBiYXNlOyBjcmVhdGUgR1BJTygpCj4gICAgIG1hY3JvIHRvIHJldHVybiBhIHBhcnRp Y3VsYXIgZ3BpbyBhZGRyZXNzIGFuZCBtb3ZlIHRoZSBlbnVtIG91dCBvZgo+ICAgICBpOTE1X3Jl Zy5oIChzdWdnZXN0ZWQgYnkgSmFuaSkKPiAKPiB2MzogTW92ZSBiYXNlIG9mZnNldCBpbnNpZGUg dGhlIEdQSU8oKSBtYWNybyBzbyB0aGUgR01CVVMgZGVmaW5lcyBkb24ndAo+ICAgICBhY3R1YWxs eSBuZWVkIHRvIGJlIGNoYW5nZWQgKHN1Z2dlc3RlZCBieSBEYW5pZWwvVmlsbGUpCj4gCj4gU2ln bmVkLW9mZi1ieTogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9oYW5kbGVycy5jIHwgIDIgKy0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgfCAgMyArKy0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9yZWcuaCAgICAgfCAyNCArKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgfCAxNiArKysrKysrKysrKysrKysr Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5jICAgIHwgMTIgKysrKy0tLS0tLS0t Cj4gIDUgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9oYW5kbGVycy5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2hhbmRsZXJzLmMKPiBpbmRleCA3YTU4Y2E1NTUxOTcuLmVj ZmY4NjZiYmJmMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvaGFuZGxl cnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9oYW5kbGVycy5jCj4gQEAgLTIx MTgsNyArMjExOCw3IEBAIHN0YXRpYyBpbnQgaW5pdF9nZW5lcmljX21taW9faW5mbyhzdHJ1Y3Qg aW50ZWxfZ3Z0ICpndnQpCj4gIAo+ICAJTU1JT19GKFBDSF9HTUJVUzAsIDQgKiA0LCAwLCAwLCAw LCBEX0FMTCwgZ21idXNfbW1pb19yZWFkLAo+ICAJCWdtYnVzX21taW9fd3JpdGUpOwo+IC0JTU1J T19GKFBDSF9HUElPQSwgNiAqIDQsIEZfVU5BTElHTiwgMCwgMCwgRF9BTEwsIE5VTEwsIE5VTEwp Owo+ICsJTU1JT19GKEdQSU8oR1BJT0EpLCA2ICogNCwgRl9VTkFMSUdOLCAwLCAwLCBEX0FMTCwg TlVMTCwgTlVMTCk7CgpJIGhhdmUgbm8gaWRlYSBvZiBncGlvX21taW9fYmFzZSBpcyBwb3B1bGF0 ZWQgY29ycmVjdGx5IGF0IHRoaXMgcG9pbnQKZm9yIGd2dCwgYW5kIEknbSB0b28gbGF6eSB0byBm aW5kIG91dC4KCj4gIAlNTUlPX0YoX01NSU8oMHhlNGYwMCksIDB4MjgsIDAsIDAsIDAsIERfQUxM LCBOVUxMLCBOVUxMKTsKPiAgCj4gIAlNTUlPX0YoX01NSU8oX1BDSF9EUEJfQVVYX0NIX0NUTCks IDYgKiA0LCAwLCAwLCAwLCBEX1BSRV9TS0wsIE5VTEwsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o Cj4gaW5kZXggYjMxZDQ4Y2Y3YTY5Li41OTZlNzM0YTg3NGYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPiBAQCAtMTYxMSw3ICsxNjExLDggQEAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg ewo+ICAJc3RydWN0IG11dGV4IGdtYnVzX211dGV4Owo+ICAKPiAgCS8qKgo+IC0JICogQmFzZSBh ZGRyZXNzIG9mIHRoZSBnbWJ1cyBhbmQgZ3BpbyBibG9jay4KPiArCSAqIEJhc2UgYWRkcmVzcyBv ZiB3aGVyZSB0aGUgZ21idXMgYW5kIGdwaW8gYmxvY2tzIGFyZSBsb2NhdGVkIChlaXRoZXIKPiAr CSAqIG9uIFBDSCBvciBvbiBTb0MgZm9yIHBsYXRmb3JtcyB3aXRob3V0IFBDSCkuCj4gIAkgKi8K PiAgCXVpbnQzMl90IGdwaW9fbW1pb19iYXNlOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgK PiBpbmRleCAxZjIyMmFmMDMyNGQuLjVlM2JhOTg5OGY0ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9yZWcuaAo+IEBAIC0zMDg5LDE4ICszMDg5LDkgQEAgZW51bSBpOTE1X3Bvd2VyX3dlbGxfaWQg ewo+ICAvKgo+ICAgKiBHUElPIHJlZ3MKPiAgICovCj4gLSNkZWZpbmUgR1BJT0EJCQlfTU1JTygw eDUwMTApCj4gLSNkZWZpbmUgR1BJT0IJCQlfTU1JTygweDUwMTQpCj4gLSNkZWZpbmUgR1BJT0MJ CQlfTU1JTygweDUwMTgpCj4gLSNkZWZpbmUgR1BJT0QJCQlfTU1JTygweDUwMWMpCj4gLSNkZWZp bmUgR1BJT0UJCQlfTU1JTygweDUwMjApCj4gLSNkZWZpbmUgR1BJT0YJCQlfTU1JTygweDUwMjQp Cj4gLSNkZWZpbmUgR1BJT0cJCQlfTU1JTygweDUwMjgpCj4gLSNkZWZpbmUgR1BJT0gJCQlfTU1J TygweDUwMmMpCj4gLSNkZWZpbmUgR1BJT0oJCQlfTU1JTygweDUwMzQpCj4gLSNkZWZpbmUgR1BJ T0sJCQlfTU1JTygweDUwMzgpCj4gLSNkZWZpbmUgR1BJT0wJCQlfTU1JTygweDUwM0MpCj4gLSNk ZWZpbmUgR1BJT00JCQlfTU1JTygweDUwNDApCj4gKyNkZWZpbmUgR1BJTyhncGlvKQkJX01NSU8o ZGV2X3ByaXYtPmdwaW9fbW1pb19iYXNlICsgMHg1MDEwICsgXAo+ICsJCQkJICAgICAgNCAqIChn cGlvKSkKPiArCj4gICMgZGVmaW5lIEdQSU9fQ0xPQ0tfRElSX01BU0sJCSgxIDw8IDApCj4gICMg ZGVmaW5lIEdQSU9fQ0xPQ0tfRElSX0lOCQkoMCA8PCAxKQo+ICAjIGRlZmluZSBHUElPX0NMT0NL X0RJUl9PVVQJCSgxIDw8IDEpCj4gQEAgLTc0ODMsNiArNzQ3NCw4IEBAIGVudW0gewo+ICAKPiAg LyogUENIICovCj4gIAo+ICsjZGVmaW5lIFBDSF9ESVNQTEFZX0JBU0UJMHhjMDAwMHUKPiArCj4g IC8qIHNvdXRoIGRpc3BsYXkgZW5naW5lIGludGVycnVwdDogSUJYICovCj4gICNkZWZpbmUgU0RF X0FVRElPX1BPV0VSX0QJKDEgPDwgMjcpCj4gICNkZWZpbmUgU0RFX0FVRElPX1BPV0VSX0MJKDEg PDwgMjYpCj4gQEAgLTc2NzEsMTMgKzc2NjQsNiBAQCBlbnVtIHsKPiAgI2RlZmluZSAgIElDUF9U Q19IUERfTE9OR19ERVRFQ1QodGNfcG9ydCkJKDIgPDwgKHRjX3BvcnQpICogNCkKPiAgI2RlZmlu ZSAgIElDUF9UQ19IUERfU0hPUlRfREVURUNUKHRjX3BvcnQpCSgxIDw8ICh0Y19wb3J0KSAqIDQp Cj4gIAo+IC0jZGVmaW5lIFBDSF9HUElPQSAgICAgICAgICAgICAgIF9NTUlPKDB4YzUwMTApCj4g LSNkZWZpbmUgUENIX0dQSU9CICAgICAgICAgICAgICAgX01NSU8oMHhjNTAxNCkKPiAtI2RlZmlu ZSBQQ0hfR1BJT0MgICAgICAgICAgICAgICBfTU1JTygweGM1MDE4KQo+IC0jZGVmaW5lIFBDSF9H UElPRCAgICAgICAgICAgICAgIF9NTUlPKDB4YzUwMWMpCj4gLSNkZWZpbmUgUENIX0dQSU9FICAg ICAgICAgICAgICAgX01NSU8oMHhjNTAyMCkKPiAtI2RlZmluZSBQQ0hfR1BJT0YgICAgICAgICAg ICAgICBfTU1JTygweGM1MDI0KQo+IC0KPiAgI2RlZmluZSBQQ0hfR01CVVMwCQlfTU1JTygweGM1 MTAwKQo+ICAjZGVmaW5lIFBDSF9HTUJVUzEJCV9NTUlPKDB4YzUxMDQpCj4gICNkZWZpbmUgUENI X0dNQlVTMgkJX01NSU8oMHhjNTEwOCkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4 IGIwOWI2Mzg5YTczNC4uMmQxMDJmOTViMzhlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2 LmgKPiBAQCAtMTUyLDYgKzE1MiwyMiBAQAo+ICAgKiBEaXNwbGF5IHJlbGF0ZWQgc3R1ZmYKPiAg ICovCj4gIAo+ICtlbnVtIGk5MTVfZ3BpbyB7Cj4gKwlHUElPQSA9IDAsCgo9MCBub3QgcmVhbGx5 IG5lZWRlZAoKPiArCUdQSU9CLAo+ICsJR1BJT0MsCj4gKwlHUElPRCwKPiArCUdQSU9FLAo+ICsJ R1BJT0YsCj4gKwlHUElPRywKPiArCUdQSU9ILAo+ICsJX19HUElPSV9VTlVTRUQsCj4gKwlHUElP SiwKPiArCUdQSU9LLAo+ICsJR1BJT0wsCj4gKwlHUElPTSwKPiArfTsKCldlcmVuJ3QgbW9zdCB0 aGluZ3MgbGlrZSB0aGlzIG1vdmVkIGludG8gaW50ZWxfZGlzcGxheS5oIGEgd2hpbGUgYmFjaz8K Cj4gKwo+ICAvKiBzdG9yZSBpbmZvcm1hdGlvbiBhYm91dCBhbiBJeHh4IERWTyAqLwo+ICAvKiBU aGUgaTgzMC0+aTg2NSB1c2UgbXVsdGlwbGUgRFZPcyB3aXRoIG11bHRpcGxlIGkyY3MgKi8KPiAg LyogdGhlIGk5MTUsIGk5NDUgaGF2ZSBhIHNpbmdsZSBzRFZPIGkyYyBidXMgLSB3aGljaCBpcyBk aWZmZXJlbnQgKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJj LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9pMmMuYwo+IGluZGV4IGJlZjMyYjdjMjQ4 ZS4uZjAzYzdjYTcxOGI1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2kyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJjLmMKPiBAQCAtMzcs NyArMzcsNyBAQAo+ICAKPiAgc3RydWN0IGdtYnVzX3BpbiB7Cj4gIAljb25zdCBjaGFyICpuYW1l Owo+IC0JaTkxNV9yZWdfdCByZWc7Cj4gKwllbnVtIGk5MTVfZ3BpbyBncGlvOwo+ICB9Owo+ICAK PiAgLyogTWFwIGdtYnVzIHBpbiBwYWlycyB0byBuYW1lcyBhbmQgcmVnaXN0ZXJzLiAqLwo+IEBA IC0xMjEsOCArMTIxLDcgQEAgYm9vbCBpbnRlbF9nbWJ1c19pc192YWxpZF9waW4oc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJZWxzZQo+ICAJCXNpemUgPSBBUlJBWV9TSVpF KGdtYnVzX3BpbnMpOwo+ICAKPiAtCXJldHVybiBwaW4gPCBzaXplICYmCj4gLQkJaTkxNV9tbWlv X3JlZ192YWxpZChnZXRfZ21idXNfcGluKGRldl9wcml2LCBwaW4pLT5yZWcpOwo+ICsJcmV0dXJu IHBpbiA8IHNpemUgJiYgZ2V0X2dtYnVzX3BpbihkZXZfcHJpdiwgcGluKS0+bmFtZTsKPiAgfQo+ ICAKPiAgLyogSW50ZWwgR1BJTyBhY2Nlc3MgZnVuY3Rpb25zICovCj4gQEAgLTI5Miw4ICsyOTEs NyBAQCBpbnRlbF9ncGlvX3NldHVwKHN0cnVjdCBpbnRlbF9nbWJ1cyAqYnVzLCB1bnNpZ25lZCBp bnQgcGluKQo+ICAKPiAgCWFsZ28gPSAmYnVzLT5iaXRfYWxnbzsKPiAgCj4gLQlidXMtPmdwaW9f cmVnID0gX01NSU8oZGV2X3ByaXYtPmdwaW9fbW1pb19iYXNlICsKPiAtCQkJICAgICAgaTkxNV9t bWlvX3JlZ19vZmZzZXQoZ2V0X2dtYnVzX3BpbihkZXZfcHJpdiwgcGluKS0+cmVnKSk7Cj4gKwli dXMtPmdwaW9fcmVnID0gR1BJTyhnZXRfZ21idXNfcGluKGRldl9wcml2LCBwaW4pLT5ncGlvKTsK PiAgCWJ1cy0+YWRhcHRlci5hbGdvX2RhdGEgPSBhbGdvOwo+ICAJYWxnby0+c2V0c2RhID0gc2V0 X2RhdGE7Cj4gIAlhbGdvLT5zZXRzY2wgPSBzZXRfY2xvY2s7Cj4gQEAgLTgyNSw5ICs4MjMsNyBA QCBpbnQgaW50ZWxfc2V0dXBfZ21idXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAJaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3By aXYpKQo+ICAJCWRldl9wcml2LT5ncGlvX21taW9fYmFzZSA9IFZMVl9ESVNQTEFZX0JBU0U7Cj4g IAllbHNlIGlmICghSEFTX0dNQ0hfRElTUExBWShkZXZfcHJpdikpCgpJIHdhcyBzbGlnaHRseSBj b25mdXNlZCBieSB0aGlzIHVudGlsIEkgcmVtZWJlciB0aGF0IEJYVCB1c2VzIHRoZSBQQ0gKb2Zm c2V0cyBmb3IgdGhlIHNvdXRoIHN0dWZmIGV2ZW4gdGhvdWdoIGl0IGRvZXNuJ3QgaGF2ZSBhIFBD SC4gTWlnaHQKd2FudCB0byBhZGQgYSBjb21tZW50IGhlcmUgdG8gdW5jb25mdXNlIG1hdHRlci4K Cj4gLQkJZGV2X3ByaXYtPmdwaW9fbW1pb19iYXNlID0KPiAtCQkJaTkxNV9tbWlvX3JlZ19vZmZz ZXQoUENIX0dQSU9BKSAtCj4gLQkJCWk5MTVfbW1pb19yZWdfb2Zmc2V0KEdQSU9BKTsKPiArCQlk ZXZfcHJpdi0+Z3Bpb19tbWlvX2Jhc2UgPSBQQ0hfRElTUExBWV9CQVNFOwo+ICAKPiAgCW11dGV4 X2luaXQoJmRldl9wcml2LT5nbWJ1c19tdXRleCk7Cj4gIAlpbml0X3dhaXRxdWV1ZV9oZWFkKCZk ZXZfcHJpdi0+Z21idXNfd2FpdF9xdWV1ZSk7Cj4gLS0gCj4gMi4xNy4xCgotLSAKVmlsbGUgU3ly asOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=