All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com,
	miquel.raynal@bootlin.com, nadavh@marvell.com,
	stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com
Subject: Re: [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for classifier flows
Date: Sat, 14 Jul 2018 13:20:47 +0200	[thread overview]
Message-ID: <20180714132047.43a03fab@bootlin.com> (raw)
In-Reply-To: <20180713161344.19872-5-maxime.chevallier@bootlin.com>

On Fri, 13 Jul 2018 18:13:43 +0200
Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:


>+static int mvpp2_dbgfs_flow_id_show(struct seq_file *s, void *unused)
>+{
>+	struct mvpp2_dbgfs_flow_entry *entry = s->private;
>+	struct mvpp2_cls_flow *f;
>+
>+	f = mvpp2_cls_flow_get(entry->flow);

This won't compile with commit
9cee8c437543 ("net: mvpp2: mvpp2_cls_flow_get() can be static")

I should have seen that missing static in the RSS series, now that
it's fixed I'll send a V2 of that debugfs series, to make that function
non static for the right reason this time.

Thanks,

Maxime

  reply	other threads:[~2018-07-14 11:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 16:13 [PATCH net-next 0/5] net: mvpp2: add debugfs interface Maxime Chevallier
2018-07-13 16:13 ` [PATCH net-next 1/5] net: mvpp2: switch to SPDX identifiers Maxime Chevallier
2018-07-13 16:13 ` [PATCH net-next 2/5] net: mvpp2: add a debugfs interface for the Header Parser Maxime Chevallier
2018-07-13 16:13 ` [PATCH net-next 3/5] net: mvpp2: debugfs: add hit counter stats for Header Parser entries Maxime Chevallier
2018-07-13 16:13 ` [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for classifier flows Maxime Chevallier
2018-07-14 11:20   ` Maxime Chevallier [this message]
2018-07-17  1:01   ` kbuild test robot
2018-07-13 16:13 ` [PATCH net-next 5/5] net: mvpp2: debugfs: add classifier hit counters Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180714132047.43a03fab@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=antoine.tenart@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.