From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54175 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbeGOKns (ORCPT ); Sun, 15 Jul 2018 06:43:48 -0400 Date: Sun, 15 Jul 2018 12:21:18 +0200 From: Greg KH To: Scott Bauer Cc: stable@vger.kernel.org, Jon Derrick , Keith Busch Subject: Re: [BACKPORT PATCH] nvme-pci: Remap CMB SQ entries on every controller reset Message-ID: <20180715102118.GA8049@kroah.com> References: <20180712212717.15318-1-scott.bauer@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180712212717.15318-1-scott.bauer@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jul 12, 2018 at 03:27:17PM -0600, Scott Bauer wrote: > Commit 815c6704bf9f1c59f3a6be380a4032b9c57b12f1 upstream. > > The controller memory buffer is remapped into a kernel address on each > reset, but the driver was setting the submission queue base address > only on the very first queue creation. The remapped address is likely to > change after a reset, so accessing the old address will hit a kernel bug. > > This patch fixes that by setting the queue's CMB base address each time > the queue is created. > > Fixes: f63572dff1421 ("nvme: unmap CMB and remove sysfs file in reset path") > Reported-by: Christian Black > Cc: Jon Derrick > Signed-off-by: Keith Busch > Reviewed-by: Christoph Hellwig > Signed-off-by: Scott Bauer > Reviewed-by: Jon Derrick > --- > drivers/nvme/host/pci.c | 27 ++++++++++++++++----------- > 1 file changed, 16 insertions(+), 11 deletions(-) Now queued up, thanks. greg k-h