From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y Date: Sun, 15 Jul 2018 13:26:05 +0200 Message-ID: <20180715112605.GA31680@kroah.com> References: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fefAJ-0007Jv-Fy for xen-devel@lists.xenproject.org; Sun, 15 Jul 2018 11:26:11 +0000 Content-Disposition: inline In-Reply-To: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "Srivatsa S. Bhat" Cc: Dave Hansen , Wanpeng Li , ak@linux.intel.com, linux-tip-commits@vger.kernel.org, Piotr Luc , Mel Gorman , arjan.van.de.ven@intel.com, xen-devel@lists.xenproject.org, Alexander Sergeyev , Brian Gerst , Andy Lutomirski , =?iso-8859-1?Q?Micka=EBlSala=FCn?= , Thomas Gleixner , Joe Konno , Laura Abbott , Will Drewry , Jiri Kosina , linux-kernel@vger.kernel.org, Jia Zhang , Andrew Morton , torvalds@linux-foundation.org, dwmw@amazon.co.uk, karahmed@amazon.de, dave.hansen@linux.intel.com, linux@dominikbrodowski.net, Bo Gan , Andrey Ryabinin List-Id: xen-devel@lists.xenproject.org T24gU2F0LCBKdWwgMTQsIDIwMTggYXQgMDI6MjU6NDNBTSAtMDcwMCwgU3JpdmF0c2EgUy4gQmhh dCB3cm90ZToKPiBIaSBHcmVnLAo+IAo+IFRoaXMgcGF0Y2ggc2VyaWVzIGlzIGEgYmFja3BvcnQg b2YgdGhlIFNwZWN0cmUtdjIgZml4ZXMgKElCUEIvSUJSUykKPiBhbmQgcGF0Y2hlcyBmb3IgdGhl IFNwZWN1bGF0aXZlIFN0b3JlIEJ5cGFzcyB2dWxuZXJhYmlsaXR5IHRvIDQuNC55Cj4gKHRoZXkg YXBwbHkgY2xlYW5seSBvbiB0b3Agb2YgNC40LjE0MCkuCj4gCj4gSSB1c2VkIDQuOS55IGFzIG15 IHJlZmVyZW5jZSB3aGVuIGJhY2twb3J0aW5nIHRvIDQuNC55IChhcyBJIHRob3VnaHQKPiB0aGF0 IHdvdWxkIG1pbmltaXplIHRoZSBhbW91bnQgb2YgZml4aW5nIHVwIG5lY2Vzc2FyeSkuIFVuZm9y dHVuYXRlbHkKPiBJIGhhZCB0byBza2lwIHRoZSBLVk0gZml4ZXMgZm9yIHRoZXNlIHZ1bG5lcmFi aWxpdGllcywgYXMgdGhlIEtWTQo+IGNvZGViYXNlIGlzIGRyYXN0aWNhbGx5IGRpZmZlcmVudCBp biA0LjQgYXMgY29tcGFyZWQgdG8gNC45LiAoSSB0cmllZAo+IG15IGJlc3QgdG8gYmFja3BvcnQg dGhlbSBpbml0aWFsbHksIGJ1dCB3YXNuJ3QgY29uZmlkZW50IHRoYXQgdGhleQo+IHdlcmUgY29y cmVjdCwgc28gSSBkZWNpZGVkIHRvIGRyb3AgdGhlbSBmcm9tIHRoaXMgc2VyaWVzKS4KPiAKPiBZ b3UnbGwgbm90aWNlIHRoYXQgdGhlIGluaXRpYWwgZmV3IHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMg aW5jbHVkZQo+IGNsZWFudXBzIGV0Yy4sIHRoYXQgYXJlIG5vbi1jcml0aWNhbCB0byBJQlBCL0lC UlMvU1NCRC4gTW9zdCBvZiB0aGVzZQo+IHBhdGNoZXMgYXJlIGFpbWVkIGF0IGdldHRpbmcgdGhl IGNwdWZlYXR1cmUuaCB2cyBjcHVmZWF0dXJlcy5oIHNwbGl0Cj4gaW50byA0LjQsIHNpbmNlIGEg bG90IG9mIHRoZSBzdWJzZXF1ZW50IHBhdGNoZXMgdXBkYXRlIHRoZXNlIGhlYWRlcnMuCj4gT24g bXkgZmlyc3QgYXR0ZW1wdCB0byBiYWNrcG9ydCB0aGVzZSBwYXRjaGVzIHRvIDQuNC55LCBJIGhh ZCBhY3R1YWxseQo+IHRyaWVkIHRvIGRvIGFsbCB0aGUgdXBkYXRlcyBvbiB0aGUgY3B1ZmVhdHVy ZS5oIGZpbGUgaXRzZWxmLCBidXQgaXQKPiBzdGFydGVkIGdldHRpbmcgdmVyeSBjdW1iZXJzb21l LCBzbyBJIHJlc29ydGVkIHRvIGJhY2twb3J0aW5nIHRoZQo+IGNwdWZlYXR1cmUuaCB2cyBjcHVm ZWF0dXJlcy5oIHNwbGl0IGFuZCB0aGVpciBkZXBlbmRlbmNpZXMgYXMgd2VsbC4gSQo+IHRoaW5r IGFwYXJ0IGZyb20gdGhlc2UgaW5pdGlhbCBwYXRjaGVzLCB0aGUgcmVzdCBvZiB0aGUgcGF0Y2hz ZXQKPiBkb2Vzbid0IGhhdmUgYWxsIHRoYXQgbXVjaCBub2lzZS4gCgpJJ3ZlIGFwcGxpZWQgdGhl ICJpbml0aWFsIiBwYXRjaGVzIHRvIHRoZSA0LjQtc3RhYmxlIHF1ZXVlIHJpZ2h0IG5vdywgYXMK dGhvc2Ugd2VyZSBhbGwganVzdCAiaG91c2VrZWVwaW5nIiBzdHVmZi4gIEknbGwgbGV0IG90aGVy cyByZXZpZXcgdGhlCnJlc3Qgb2YgdGhlIHNlcmllcyB0aGlzIHdlZWsgYW5kIHNlZSBpZiBhbnlv bmUgb2JqZWN0cyBiZWZvcmUgdGhyb3dpbmcKdGhlbSBhdCB0aGUgdGVzdC1ib3RzLgoKTWFueSB0 aGFua3MgZm9yIGRvaW5nIGFsbCBvZiB0aGlzIHdvcmsuCgpncmVnIGstaAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f69.google.com (mail-pl0-f69.google.com [209.85.160.69]) by kanga.kvack.org (Postfix) with ESMTP id 4BECC6B0007 for ; Sun, 15 Jul 2018 07:26:10 -0400 (EDT) Received: by mail-pl0-f69.google.com with SMTP id y2-v6so13118318pll.16 for ; Sun, 15 Jul 2018 04:26:10 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id a7-v6si27023787plz.510.2018.07.15.04.26.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Jul 2018 04:26:09 -0700 (PDT) Date: Sun, 15 Jul 2018 13:26:05 +0200 From: Greg KH Subject: Re: [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y Message-ID: <20180715112605.GA31680@kroah.com> References: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> Sender: owner-linux-mm@kvack.org List-ID: To: "Srivatsa S. Bhat" Cc: stable@vger.kernel.org, Denys Vlasenko , Bo Gan , Konrad Rzeszutek Wilk , Borislav Petkov , Thomas Gleixner , Ricardo Neri , Tom Lendacky , ak@linux.intel.com, linux-tip-commits@vger.kernel.org, Jia Zhang , Josh Poimboeuf , xen-devel@lists.xenproject.org, =?utf-8?B?S3LEjW3DocWZ?= , Peter Zijlstra , Andy Lutomirski , Arnaldo Carvalho de Melo , Sherry Hurwitz , Kees Cook , linux-kernel@vger.kernel.org, Shuah Khan , Oleg Nesterov , torvalds@linux-foundation.org, dwmw@amazon.co.uk, karahmed@amazon.de, Borislav Petkov , dave.hansen@linux.intel.com, linux@dominikbrodowski.net, Quentin Casasnovas , Joerg Roedel , Alexander Shishkin , Kyle Huey , Will Drewry , Andrey Ryabinin , "H. Peter Anvin" , Brian Gerst , Kristen Carlson Accardi , Thomas Garnier , Andrew Morton , Joe Konno , kvm , Piotr Luc , boris.ostrovsky@oracle.com, Jan Beulich , arjan@linux.intel.com, Alexander Kuleshov , Juergen Gross , Ross Zwisler , =?iso-8859-1?Q?J=F6rg?= Otte , tim.c.chen@linux.intel.com, Alexander Sergeyev , Josh Triplett , gnomes@lxorguk.ukuu.org.uk, Tony Luck , Laura Abbott , dave.hansen@intel.com, Ingo Molnar , Mike Galbraith , Rik van Riel , "Kirill A. Shutemov" , Alexey Makhalov , Dave Hansen , ashok.raj@intel.com, Mel Gorman , =?iso-8859-1?Q?Micka=EBlSala=FCn?= , Fenghua Yu , "Matt Helsley (VMware)" , Vince Weaver , Prarit Bhargava , rostedt@goodmis.org, Dan Williams , Jim Mattson , Dave Young , linux-edac , Jon Masters , Jiri Kosina , Andy Lutomirski , Paolo Bonzini , Arnd Bergmann , linux-mm@kvack.org, Jiri Olsa , arjan.van.de.ven@intel.com, sironi@amazon.de, Frederic Weisbecker , Kyle Huey , Alexander Popov , Andy Shevchenko , Nadav Amit , Yazen Ghannam , Wanpeng Li , Stephane Eranian , David Woodhouse , srivatsab@vmware.com On Sat, Jul 14, 2018 at 02:25:43AM -0700, Srivatsa S. Bhat wrote: > Hi Greg, > > This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) > and patches for the Speculative Store Bypass vulnerability to 4.4.y > (they apply cleanly on top of 4.4.140). > > I used 4.9.y as my reference when backporting to 4.4.y (as I thought > that would minimize the amount of fixing up necessary). Unfortunately > I had to skip the KVM fixes for these vulnerabilities, as the KVM > codebase is drastically different in 4.4 as compared to 4.9. (I tried > my best to backport them initially, but wasn't confident that they > were correct, so I decided to drop them from this series). > > You'll notice that the initial few patches in this series include > cleanups etc., that are non-critical to IBPB/IBRS/SSBD. Most of these > patches are aimed at getting the cpufeature.h vs cpufeatures.h split > into 4.4, since a lot of the subsequent patches update these headers. > On my first attempt to backport these patches to 4.4.y, I had actually > tried to do all the updates on the cpufeature.h file itself, but it > started getting very cumbersome, so I resorted to backporting the > cpufeature.h vs cpufeatures.h split and their dependencies as well. I > think apart from these initial patches, the rest of the patchset > doesn't have all that much noise. I've applied the "initial" patches to the 4.4-stable queue right now, as those were all just "housekeeping" stuff. I'll let others review the rest of the series this week and see if anyone objects before throwing them at the test-bots. Many thanks for doing all of this work. greg k-h