From: Ingo Molnar <mingo@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Ingo Molnar <mingo@redhat.com>, Dirk Gouders <dirk@gouders.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/boot: Fix if_changed build flip/flop
Date: Mon, 16 Jul 2018 00:58:49 +0200 [thread overview]
Message-ID: <20180715225849.GB30102@gmail.com> (raw)
In-Reply-To: <20180715025626.GA48623@beast>
* Kees Cook <keescook@chromium.org> wrote:
> The if_changed kbuild function can only be used once per target. If not
> it will effectively always trigger, flipping back and forth between the
> two commands getting recorded. Instead, merge the two commands into a
> single function to get stable build artifacts (i.e. .vmlinux.cmd).
>
> Reported-by: Dirk Gouders <dirk@gouders.net>
What actual symptoms does this bug have?
I.e. it would be nice if the changelog started with such an explanation:
Dirk Gouders reported that .... <bad stuff happens during kernel build> ...
and bisected it back to:
98f78525371b ("x86/boot: Refuse to build with data relocations")
The root cause of the bug is that the if_changed kbuild function ...
Or something like that.
Thanks,
Ingo
next prev parent reply other threads:[~2018-07-15 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 2:56 [PATCH] x86/boot: Fix if_changed build flip/flop Kees Cook
2018-07-15 22:58 ` Ingo Molnar [this message]
2018-07-18 5:44 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180715225849.GB30102@gmail.com \
--to=mingo@kernel.org \
--cc=dirk@gouders.net \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.