All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Todd Kjos <tkjos@android.com>,
	Jeff Vander Stoep <jeffv@google.com>, Arve H <arve@android.com>,
	Martijn Coenen <maco@android.com>,
	Tobias Lindskog <tobias.lindskog@sonymobile.com>,
	kernel-team@android.com
Subject: Re: [PATCH] staging: android: ashmem: Shrink directly through shmem_fallocate
Date: Mon, 16 Jul 2018 11:48:51 +0200	[thread overview]
Message-ID: <20180716094851.GA31480@kroah.com> (raw)
In-Reply-To: <20180706214416.184691-1-joel@joelfernandes.org>

On Fri, Jul 06, 2018 at 02:44:16PM -0700, Joel Fernandes wrote:
> From: Tobias Lindskog <tobias.lindskog@sonymobile.com>
> 
> When ashmem_shrink is called from direct reclaim on a user thread, a
> call to do_fallocate will check for permissions against the security
> policy of that user thread.  It can thus fail by chance if called on a
> thread that isn't permitted to modify the relevant ashmem areas.
> 
> Because we know that we have a shmem file underneath, call the shmem
> implementation of fallocate directly instead of going through the
> user-space interface for fallocate.
> 
> Bug: 21951515

What does this "Bug:" line mean to any of us?  :)

I'll go delete it, and I fixed up the subject to have 'staging: android'
in it as well.  Please do that next time.

thanks,

greg k-h

  reply	other threads:[~2018-07-16  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 21:44 [PATCH] ashmem: Shrink directly through shmem_fallocate Joel Fernandes
2018-07-16  9:48 ` Greg Kroah-Hartman [this message]
2018-07-16 20:22   ` [PATCH] staging: android: " Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716094851.GA31480@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jeffv@google.com \
    --cc=joel@joelfernandes.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=tkjos@android.com \
    --cc=tobias.lindskog@sonymobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.