All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc
Date: Mon, 16 Jul 2018 10:06:46 -0700	[thread overview]
Message-ID: <20180716100646.788fc9c0@xeon-e3> (raw)
In-Reply-To: <20180716163926.4826-1-toke@toke.dk>

On Mon, 16 Jul 2018 18:39:26 +0200
Toke Høiland-Jørgensen <toke@toke.dk> wrote:

> +#define PRINT_TSTAT(name, attr, fmts, val)	do {		\
> +			if (GET_TSTAT(0, attr)) {		\
> +				fprintf(f, name);		\
> +				for (i = 0; i < num_tins; i++)	\
> +					fprintf(f, " %12" fmts,	val);	\
> +				fprintf(f, "\n");			\
> +			}						\
> +		} while (0)

Couldn't this be a function?

  reply	other threads:[~2018-07-16 17:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 16:39 [PATCH iproute2-next v10] Add support for CAKE qdisc Toke Høiland-Jørgensen
2018-07-16 17:06 ` Stephen Hemminger [this message]
2018-07-16 17:56   ` [Cake] " Toke Høiland-Jørgensen
2018-07-16 17:58     ` Stephen Hemminger
2018-07-18  2:31 ` David Ahern
2018-07-19 10:53   ` Toke Høiland-Jørgensen
2018-07-19 14:55     ` David Ahern
2018-07-19 15:20       ` Toke Høiland-Jørgensen
2018-07-19 15:22         ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716100646.788fc9c0@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=cake@lists.bufferbloat.net \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.