All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	broonie@kernel.org, p.paillet@st.com,
	linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
	Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH v2] base: core: Remove WARN_ON from link dependencies check
Date: Mon, 16 Jul 2018 12:27:35 +0200	[thread overview]
Message-ID: <20180716102735.GA6269@kroah.com> (raw)
In-Reply-To: <1753469.EDefOSO2YU@aspire.rjw.lan>

On Mon, Jul 16, 2018 at 12:07:20PM +0200, Rafael J. Wysocki wrote:
> On Monday, July 16, 2018 11:59:52 AM CEST Benjamin Gaignard wrote:
> > In some cases the link between between customer and supplier
> > already exist, for example when a device use it parent as supplier [1].
> 
> I think this should be "its parent as a supplier".
> 
> > Do not warn about already existing dependencies because device_link_add()
> > take care of this case.
> 
> "device_link_add() takes care of"
> 
> > [1] https://lkml.org/lkml/2018/7/9/356
> 
> There is the Link: tag for links and it is better to not use lkml.org
> as it is not reliable enough.  You can use lore.kernel.org/lkml/ instead.

Even better, use:
	lkml.kernel.org/r/[message-id]

thanks,

greg k-h

  reply	other threads:[~2018-07-16 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16  9:59 [PATCH v2] base: core: Remove WARN_ON from link dependencies check Benjamin Gaignard
2018-07-16 10:07 ` Rafael J. Wysocki
2018-07-16 10:27   ` Greg KH [this message]
2018-07-16 10:40     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716102735.GA6269@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=benjamin.gaignard@linaro.org \
    --cc=benjamin.gaignard@st.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=p.paillet@st.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.