From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc
Date: Mon, 16 Jul 2018 10:58:23 -0700
Message-ID: <20180716105823.626b8a81@xeon-e3>
References: <20180716163926.4826-1-toke@toke.dk>
        <20180716100646.788fc9c0@xeon-e3>
        <87o9f75akv.fsf@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= <toke@toke.dk>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f194.google.com ([209.85.215.194]:35398 "EHLO
        mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727797AbeGPS04 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 16 Jul 2018 14:26:56 -0400
Received: by mail-pg1-f194.google.com with SMTP id e6-v6so7803696pgv.2
        for <netdev@vger.kernel.org>; Mon, 16 Jul 2018 10:58:26 -0700 (PDT)
In-Reply-To: <87o9f75akv.fsf@toke.dk>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 16 Jul 2018 19:56:00 +0200
Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:

> Stephen Hemminger <stephen@networkplumber.org> writes:
>=20
> > On Mon, 16 Jul 2018 18:39:26 +0200
> > Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:
> > =20
> >> +#define PRINT_TSTAT(name, attr, fmts, val)	do {		\
> >> +			if (GET_TSTAT(0, attr)) {		\
> >> +				fprintf(f, name);		\
> >> +				for (i =3D 0; i < num_tins; i++)	\
> >> +					fprintf(f, " %12" fmts,	val);	\
> >> +				fprintf(f, "\n");			\
> >> +			}						\
> >> +		} while (0) =20
> >
> > Couldn't this be a function? =20
>=20
> Guess so? But keeping it as a macro keeps it closer to where it is
> defined, and keeps the macro definitions together. IMO this is more
> readable than splitting things up...
>=20
> -Toke

Personal preference. I hate macros, leftover from hours of debugging
bad expansions.