From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
Cc: viro@zeniv.linux.org.uk,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: FAT: Operating on broken FAT FS causes the write syscall to return negative number not equal to -1
Date: Mon, 16 Jul 2018 14:17:34 +0100 [thread overview]
Message-ID: <20180716141734.01ddee8c@alans-desktop> (raw)
In-Reply-To: <CAE5jQCcs2x4myTHUhNmHPZvhMuPsrkzLmiqqeF5wzZ-Hf5druQ@mail.gmail.com>
> Oops, I was just doing some testing and thought that correct behavior
> for crafted FS is to return arbitrary valid error code (like -EIO) or
> some arbitrary data, say, not larger than FS (not disclosing the
> kernel memory, of course). Please excuse me if I was wrong. If fixing
> this would slow down some hot code path, then I am not insisting on
> returning valid errno. :)
>
> Meanwhile, how should be considered such discrepancies with man pages
> for invalid FS images: should it be considered low priority bug,
> not-a-bug or feature request (diagnostics)?
If you can crash the machine or exploit it with a carefully crafted disk
then its serious. If you get weird behaviour only it's not too serious.
It's nice (but often not possible) if a filesystem at least forces itself
R/O when it detects a corruption to avoid doing more damage.
Alan
prev parent reply other threads:[~2018-07-16 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 12:24 FAT: Operating on broken FAT FS causes the write syscall to return negative number not equal to -1 Anatoly Trosinenko
2018-07-15 14:20 ` OGAWA Hirofumi
2018-07-15 14:30 ` Al Viro
2018-07-15 15:08 ` [PATCH v2] " OGAWA Hirofumi
2018-07-15 15:08 ` Anatoly Trosinenko
2018-07-15 15:26 ` OGAWA Hirofumi
2018-07-15 15:35 ` Anatoly Trosinenko
2018-07-16 13:17 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716141734.01ddee8c@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=anatoly.trosinenko@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.