Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

From: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	tiwai-IBi9RG/b67k@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Jim Qu <Jim.Qu-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	daniel-/w4YWyX8dFk@public.gmane.org,
	alexander.deucher-5C7GfCeVMHo@public.gmane.org
Subject: Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function
Date: Mon, 16 Jul 2018 16:51:12 +0200	[thread overview]
Message-ID: <20180716145112.GA28849@wunner.de> (raw)
In-Reply-To: <s5hmuur44r4.wl-tiwai-l3A5Bk7waGM@public.gmane.org>

On Mon, Jul 16, 2018 at 04:47:11PM +0200, Takashi Iwai wrote:
> On Mon, 16 Jul 2018 16:43:42 +0200,
> Lukas Wunner wrote:
> > 
> > On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote:
> > > +
> > > +	list_for_each_entry(client, &vgasr_priv.clients, list) {
> > > +		if (!client_is_audio(client) || client_id(client) !=
> > > +			VGA_SWITCHEROO_UNKNOWN_ID)
> > 
> > Don't you have to check for
> > 
> >       client_id(client) != VGA_SWITCHEROO_UNKNOWN_ID | ID_BIT_AUDIO
> > 
> > here?  That's the value you assign when the audio client registers,
> > yet you're checking for something else, so you're always skipping
> > over audio clients.  Did you actually test this patch?
> 
> This should be OK, since client_id() is a macro to strip to the core
> id number without ID_BIT_AUDIO.  And client_is_vga() &
> client_is_audio() macros were rewritten along with it, too.

Okay, thanks for the clarification.

Lukas
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx