From: Nishad Kamdar <nishadkamdar@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line
Date: Mon, 16 Jul 2018 20:59:59 +0530 [thread overview]
Message-ID: <20180716152957.GA16348@nishad> (raw)
In-Reply-To: <20180715072712.GA15766@kroah.com>
On Sun, Jul 15, 2018 at 09:27:12AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 15, 2018 at 12:19:18PM +0530, Nishad Kamdar wrote:
> > Bring function argument 'struct comedi_subdevice *s' to the
> > previous line to avoid ending the line with open parenthesis.
> > Issue found by checkpatch.
>
> But now the code has another checkpatch violation, too long of a line.
> You can go back and forth submitting the same change over and over for
> forever :)
>
> Let's just leave this as-is, thanks.
>
> greg k-h
Ok noted. Thanks for reviewing.
regards,
nishad kamdar
prev parent reply other threads:[~2018-07-16 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 6:49 [PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line Nishad Kamdar
2018-07-15 7:27 ` Greg Kroah-Hartman
2018-07-16 15:29 ` Nishad Kamdar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716152957.GA16348@nishad \
--to=nishadkamdar@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.