From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v2 18/23] dt-bindings: thermal: armada: add reference to new bindings Date: Mon, 16 Jul 2018 16:32:26 +0200 Message-ID: <20180716163226.6f532579@xps13> References: <20180625151239.20976-1-miquel.raynal@bootlin.com> <20180625151239.20976-19-miquel.raynal@bootlin.com> <20180703213011.GA13190@rob-hp-laptop> <20180705120528.4b923e16@xps13> <20180706094904.22275b10@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory CLEMENT , "open list:THERMAL" , Will Deacon , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Thomas Petazzoni , Zhang Rui , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgUm9iLAoKPiA+ID4gPiA+ID4gZm9yIEFQODA2IGFuZCBDUDExMCBjb21wYXRpYmxlcy4gQWRk IGEgcmVmZXJlbmNlIHRvIHRoZXNlIGZpbGVzIGZyb20gdGhlCj4gPiA+ID4gPiA+IG9yaWdpbmFs IGRvY3VtZW50YXRpb24uCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1p cXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gPiA+ID4gPiA+IC0tLQo+ ID4gPiA+ID4gPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3RoZXJtYWwvYXJt YWRhLXRoZXJtYWwudHh0IHwgNSArKysrKwo+ID4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDUg aW5zZXJ0aW9ucygrKQo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3RoZXJtYWwvYXJtYWRhLXRoZXJtYWwudHh0IGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3RoZXJtYWwvYXJtYWRhLXRoZXJtYWwu dHh0Cj4gPiA+ID4gPiA+IGluZGV4IGUwZDAxM2EyZTY2ZC4uZjNiNDQxMTAwODkwIDEwMDY0NAo+ ID4gPiA+ID4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGhlcm1h bC9hcm1hZGEtdGhlcm1hbC50eHQKPiA+ID4gPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3RoZXJtYWwvYXJtYWRhLXRoZXJtYWwudHh0Cj4gPiA+ID4gPiA+IEBA IC0xMCw2ICsxMCwxMSBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4gPiA+ID4gPiAgICAgICog bWFydmVsbCxhcm1hZGEtYXA4MDYtdGhlcm1hbAo+ID4gPiA+ID4gPiAgICAgICogbWFydmVsbCxh cm1hZGEtY3AxMTAtdGhlcm1hbCAgCj4gPiA+ID4gPgo+ID4gPiA+ID4gUmVhbGx5IHlvdSBzaG91 bGQgbm90IGJlIHVzaW5nIHRoZSBzYW1lIGNvbXBhdGlibGUgZm9yIGJvdGguIE5vdyB5b3UKPiA+ ID4gPiA+IGhhdmUgMiBkcml2ZXJzIG1hdGNoaW5nIHRvIHNhbWUgY29tcGF0aWJsZXMuCj4gPiA+ ID4gPgo+ID4gPiA+ID4gQ2FuJ3QgeW91IG1ha2UgdGhpcyBhIGNoaWxkIG9mIHRoZSBzeXNjb24g d2l0aG91dCBicmVha2luZyB0aGUgYmluZGluZz8gIAo+ID4gPiA+Cj4gPiA+ID4gV2UgYXJlIHRh bGtpbmcgYWJvdXQgb25seSAxIGRyaXZlciBoZXJlLCBzbyBJJ20gbm90IHN1cmUgaG93IEkgc2hv dWxkCj4gPiA+ID4gdW5kZXJzdGFuZCB5b3VyIGxhc3Qgc2VudGVuY2UuIERvIHlvdSB3YW50IG1l IHRvIGFkZCBhIHNlY29uZAo+ID4gPiA+IGNvbXBhdGlibGUgKGZvciB0aGUgc2FtZSBwaWVjZSBv ZiBoYXJkd2FyZSkgZm9yIHRoZXJtYWwgbm9kZSBkZWNsYXJlZAo+ID4gPiA+IGFzIGEgY2hpbGQg b2YgdGhlIHN5c2Nvbj8gIAo+ID4gPgo+ID4gPiBJIGRvbid0IGtub3cgd2hhdCBJJ20gc3VnZ2Vz dGluZy4gWW91ciBjaGFuZ2VzIGxvb2sgbGlrZSB0aGV5IGJyZWFrCj4gPiA+IGNvbXBhdGliaWxp dHkgdG8gbWUuICAKPiA+Cj4gPiBUaGVyZSBpcyBjb2RlIGluIHRoZSBkcml2ZXIgdG8gaGFuZGxl IHRoZSBsZWdhY3kgbm9uLXN5c2Nvbi1pc2ggdGhlcm1hbAo+ID4gbm9kZSAoImFybWFkYV90aGVy bWFsX3Byb2JlX2xlZ2FjeSgpIikuIEFuIG9sZCBEVCB3aXRoIGEgbmV3IGtlcm5lbAo+ID4gd291 bGQgd29yayBmaW5lLiAgCj4gCj4gT2theSwgdGhhdCdzIGdvb2QuCj4gCj4gPiA+IFdoYXQgaGFw cGVucyBpZiB5b3UgdXNlIHRoaXMgbmV3IGJpbmRpbmcgd2l0aG91dCBhbnkga2VybmVsIGNoYW5n ZT8gIAo+ID4KPiA+IEkgc3VwcG9zZSB5b3UgbWVhbiAiZHVyaW5nIHRoZSBtZXJnZSB3aW5kb3ci PyBJbiB0aGlzIGNhc2UgdGhlIGRyaXZlcgo+ID4gb2YgdGhlIHRoZXJtYWwgSVAgd2lsbCBub3Qg cHJvYmUgKGFuZCBzcGF3biBhbiBlcnJvciBpbiB0aGUgZG1lc2cpIHdpdGgKPiA+IGFwODA2L2Nw MTEwIElQcy4gQXMgdGhlIHN1cHBvcnQgaXMgcHJldHR5IG5ldyBmb3IgdGhlbSwgdGhpcyBpcyBt YXliZQo+ID4gbm90IGEgaHVnZSBpc3N1ZS4gQWxzbywgYmVmb3JlIHRoZSBEVCBjaGFuZ2VzIGFk ZGluZyB0aGVybWFsIHpvbmVzLAo+ID4ganVzdCByZXRyaWV2aW5nIHRoZSB0ZW1wZXJhdHVyZSBt aWdodCBiZSBwcmV0dHkgdXNlbGVzcy4gSG93ZXZlciwgaXQKPiA+IGlzIGFsd2F5cyBwb3NzaWJs ZSB0byBtZXJnZSB0aGUgZHJpdmVyIGNoYW5nZXMgaW4gNC4xOSBhbmQgdGhlIERUCj4gPiBjaGFu Z2VzIGluIDQuMjAuICAKPiAKPiBOb3QgdGhlIG1lcmdlIHdpbmRvdywgYnV0IGRpc3Ryb3MgKFNV U0UgYXQgbGVhc3QpIHdhbnQgdG8gYmUgYWJsZSB0bwo+IGJvb3Qgd2l0aCBjdXJyZW50IERUcyBh bmQgdGhlaXIgZGlzdHJvIChvbGQpIGtlcm5lbC4gTWF5YmUgZm9yIHRoaXMKPiBwbGF0Zm9ybSB5 b3UgZG9uJ3QgY2FyZS4KCkluZGVlZCwgSSB0aGluayB3ZSBkb24ndCBjYXJlIHRoYXQgbXVjaCBm b3IgdGhpcyBwbGF0Zm9ybS4KCkxldCBtZSByZXNlbmQgdGhlIHNlcmllcyB3aXRoIHRoZSAnaW50 ZXJydXB0JyByZWZlcmVuY2UgcmVtb3ZlZCBhcyBJCnRoaW5rIGl0IHdhcyB0aGUgbGFzdCB0aGlu ZyB0byBhZGRyZXNzLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Mon, 16 Jul 2018 16:32:26 +0200 Subject: [PATCH v2 18/23] dt-bindings: thermal: armada: add reference to new bindings In-Reply-To: References: <20180625151239.20976-1-miquel.raynal@bootlin.com> <20180625151239.20976-19-miquel.raynal@bootlin.com> <20180703213011.GA13190@rob-hp-laptop> <20180705120528.4b923e16@xps13> <20180706094904.22275b10@xps13> Message-ID: <20180716163226.6f532579@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, > > > > > > for AP806 and CP110 compatibles. Add a reference to these files from the > > > > > > original documentation. > > > > > > > > > > > > Signed-off-by: Miquel Raynal > > > > > > --- > > > > > > Documentation/devicetree/bindings/thermal/armada-thermal.txt | 5 +++++ > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/armada-thermal.txt b/Documentation/devicetree/bindings/thermal/armada-thermal.txt > > > > > > index e0d013a2e66d..f3b441100890 100644 > > > > > > --- a/Documentation/devicetree/bindings/thermal/armada-thermal.txt > > > > > > +++ b/Documentation/devicetree/bindings/thermal/armada-thermal.txt > > > > > > @@ -10,6 +10,11 @@ Required properties: > > > > > > * marvell,armada-ap806-thermal > > > > > > * marvell,armada-cp110-thermal > > > > > > > > > > Really you should not be using the same compatible for both. Now you > > > > > have 2 drivers matching to same compatibles. > > > > > > > > > > Can't you make this a child of the syscon without breaking the binding? > > > > > > > > We are talking about only 1 driver here, so I'm not sure how I should > > > > understand your last sentence. Do you want me to add a second > > > > compatible (for the same piece of hardware) for thermal node declared > > > > as a child of the syscon? > > > > > > I don't know what I'm suggesting. Your changes look like they break > > > compatibility to me. > > > > There is code in the driver to handle the legacy non-syscon-ish thermal > > node ("armada_thermal_probe_legacy()"). An old DT with a new kernel > > would work fine. > > Okay, that's good. > > > > What happens if you use this new binding without any kernel change? > > > > I suppose you mean "during the merge window"? In this case the driver > > of the thermal IP will not probe (and spawn an error in the dmesg) with > > ap806/cp110 IPs. As the support is pretty new for them, this is maybe > > not a huge issue. Also, before the DT changes adding thermal zones, > > just retrieving the temperature might be pretty useless. However, it > > is always possible to merge the driver changes in 4.19 and the DT > > changes in 4.20. > > Not the merge window, but distros (SUSE at least) want to be able to > boot with current DTs and their distro (old) kernel. Maybe for this > platform you don't care. Indeed, I think we don't care that much for this platform. Let me resend the series with the 'interrupt' reference removed as I think it was the last thing to address. Thanks, Miqu?l