From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH next] bonding: pass link-local packets to bonding master also. Date: Mon, 16 Jul 2018 16:33:53 -0700 Message-ID: <20180716163353.2fe5659c@xeon-e3> References: <20180716011246.225647-1-mahesh@bandewar.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jay Vosburgh , Andy Gospodarek , Veaceslav Falico , David Miller , Netdev , Michal Soltys , Mahesh Bandewar To: Mahesh Bandewar Return-path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:46633 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729466AbeGQADg (ORCPT ); Mon, 16 Jul 2018 20:03:36 -0400 Received: by mail-pg1-f195.google.com with SMTP id p23-v6so7971900pgv.13 for ; Mon, 16 Jul 2018 16:33:56 -0700 (PDT) In-Reply-To: <20180716011246.225647-1-mahesh@bandewar.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 15 Jul 2018 18:12:46 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Commit b89f04c61efe ("bonding: deliver link-local packets with > skb->dev set to link that packets arrived on") changed the behavior > of how link-local-multicast packets are processed. The change in > the behavior broke some legacy use cases where these packets are > expected to arrive on bonding master device also. > > This patch passes the packet to the stack with the link it arrived > on as well as passes to the bonding-master device to preserve the > legacy use case. > > Reported-by: Michal Soltys > Signed-off-by: Mahesh Bandewar Thanks for fixing this. Why not add a Fixes: tag instead of just talking about the commit? That helps the stable maintainers know which versions of the kernel need the patch.