All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/1] capnproto: new package
Date: Mon, 16 Jul 2018 17:03:16 +0200	[thread overview]
Message-ID: <20180716170316.25a89bb7@windsurf> (raw)
In-Reply-To: <1531261885-2834-1-git-send-email-JoelsonCarl@gmail.com>

Hello,

On Tue, 10 Jul 2018 16:31:25 -0600, Joel Carlson wrote:
> Adds the capnproto package. This also builds a host variant to generate
> the capnp compiler that can be used to compile message definitions into
> C++ code. Includes a patch from upstream to fix an issue with uclibc.
> 
> Signed-off-by: Koen Martens <gmc@sonologic.nl>
> Signed-off-by: Joel Carlson <JoelsonCarl@gmail.com>

Thanks, I've applied, after doing one more change.

> +CAPNPROTO_CONF_ENV += LIBS=-latomic

You can't do that unconditionally, because libatomic doesn't always
exists. This needs to be enclosed in a BR2_TOOLCHAIN_HAS_LIBATOMIC
condition.

For example, some architectures provide __atomic built-ins with gcc
4.7 (so BR2_TOOLCHAIN_HAS_ATOMIC is true), and there was no libatomic at
the time (so BR2_TOOLCHAIN_HAS_LIBATOMIC is false).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-07-16 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 22:31 [Buildroot] [PATCH v4 1/1] capnproto: new package Joel Carlson
2018-07-16 15:03 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716170316.25a89bb7@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.