From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v2 2/5] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks Date: Mon, 16 Jul 2018 14:04:04 -0400 Message-ID: <20180716180404.GV20303@art_vandelay> References: <0882f4736ba1014f3c84de3aef0813866b1911f3.1531570020.git.hamohammed.sa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x241.google.com (mail-yb0-x241.google.com [IPv6:2607:f8b0:4002:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1315F6E53E for ; Mon, 16 Jul 2018 18:04:06 +0000 (UTC) Received: by mail-yb0-x241.google.com with SMTP id x10-v6so15771059ybl.10 for ; Mon, 16 Jul 2018 11:04:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <0882f4736ba1014f3c84de3aef0813866b1911f3.1531570020.git.hamohammed.sa@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Haneen Mohammed Cc: rodrigosiqueiramelo@gmail.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBKdWwgMTQsIDIwMTggYXQgMDM6MjA6MjFQTSArMDMwMCwgSGFuZWVuIE1vaGFtbWVk IHdyb3RlOgo+IFRoaXMgcGF0Y2ggbWFwL3VubWFwIEdFTSBiYWNraW5nIG1lbW9yeSB0byBrZXJu ZWwgYWRkcmVzcyBzcGFjZQo+IGluIHByZXBhcmUvY2xlYW51cF9mYiByZXNwZWN0aXZlbHkgYW5k IGNhY2hlIHRoZSB2aXJ0dWFsIGFkZHJlc3MKPiBmb3IgbGF0ZXIgdXNlLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IEhhbmVlbiBNb2hhbW1lZCA8aGFtb2hhbW1lZC5zYUBnbWFpbC5jb20+Cj4gLS0tCj4g Q2hhbmdlcyBpbiB2MjoKPiAtIHVzZSB2a21zX2dlbV92dW5tYXAKPiAKPiAgZHJpdmVycy9ncHUv ZHJtL3ZrbXMvdmttc19wbGFuZS5jIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LQo+ICAxIGZpbGUgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX3BsYW5lLmMgYi9kcml2ZXJz L2dwdS9kcm0vdmttcy92a21zX3BsYW5lLmMKPiBpbmRleCA5Zjc1YjFlMmMxYzQuLjg3NzQ4Mzk4 NDg5NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX3BsYW5lLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX3BsYW5lLmMKPiBAQCAtNyw4ICs3LDkgQEAK PiAgICovCj4gIAo+ICAjaW5jbHVkZSAidmttc19kcnYuaCIKPiAtI2luY2x1ZGUgPGRybS9kcm1f cGxhbmVfaGVscGVyLmg+CgpuaXQ6IFRoaXMgc2VlbXMgdW5yZWxhdGVkIHRvIHRoZSBwYXRjaAoK PiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+ICsjaW5jbHVkZSA8ZHJtL2Ry bV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX3BsYW5lX2hl bHBlci5oPgo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fcGxhbmVfZnVuY3Mgdmttc19w bGFuZV9mdW5jcyA9IHsKPiAgCS51cGRhdGVfcGxhbmUJCT0gZHJtX2F0b21pY19oZWxwZXJfdXBk YXRlX3BsYW5lLAo+IEBAIC0yNCw4ICsyNSw0MSBAQCBzdGF0aWMgdm9pZCB2a21zX3ByaW1hcnlf cGxhbmVfdXBkYXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICB7Cj4gIH0KPiAgCj4gK3N0 YXRpYyBpbnQgdmttc19wcmVwYXJlX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICsJCQkg ICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiArewo+ICsJc3RydWN0IGRybV9nZW1f b2JqZWN0ICpnZW1fb2JqOwo+ICsJc3RydWN0IHZrbXNfZ2VtX29iamVjdCAqdmttc19vYmo7Cj4g Kwo+ICsJaWYgKCFzdGF0ZS0+ZmIpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJZ2VtX29iaiA9IGRy bV9nZW1fZmJfZ2V0X29iaihzdGF0ZS0+ZmIsIDApOwo+ICsJdmttc19vYmogPSBkcm1fZ2VtX3Rv X3ZrbXNfZ2VtKGdlbV9vYmopOwo+ICsJdmttc19vYmotPnZhZGRyID0gdmttc19nZW1fdm1hcChn ZW1fb2JqKTsKPiArCj4gKwlpZiAoIXZrbXNfb2JqLT52YWRkcikKCi0gdmttc19nZW1fdm1hcCgp IHJldHVybnMgRVJSX1BUUigpLCBub3QgTlVMTC4gU28gSVNfRVJSX09SX05VTEwgd291bGQgYmUK ICBtb3JlIGFwcHJvcHJpYXRlCi0gWW91IHNob3VsZG4ndCBiZSBhc3NpZ25pbmcgdGhlIHJldHVy biBvZiB2a21zX2dlbV92bWFwKCkgdG8gdmttc19vYmotPnZhZGRyCiAgc2luY2Ugdmttc19nZW1f dm1hcCgpIGFscmVhZHkgZG9lcyB0aGlzIGludGVybmFsbHkgKHdpdGggcHJvcGVyIGxvY2tzIGFu ZAogIGNoZWNrcykKClNvIHlvdSBzaG91bGQgcHJvYmFibHkgY2hhbmdlIHZrbXNfZ2VtX3ZtYXAo KSB0byByZXR1cm4gaW50IGFuZCBhY2NlcHQgYQp2a21zX29iaiB1cG9uIHdoaWNoIGl0J2xsIHBv cHVsYXRlIHZhZGRyIGZvciB5b3UuCgpTZWFuCgo+ICsJCURSTV9FUlJPUigidm1hcCBmYWlsZWRc biIpOwo+ICsKPiArCXJldHVybiBkcm1fZ2VtX2ZiX3ByZXBhcmVfZmIocGxhbmUsIHN0YXRlKTsK PiArfQo+ICsKPiArc3RhdGljIHZvaWQgdmttc19jbGVhbnVwX2ZiKHN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lLAo+ICsJCQkgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3N0YXRlKQo+ICt7 Cj4gKwlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKmdlbV9vYmo7Cj4gKwo+ICsJaWYgKCFvbGRfc3Rh dGUtPmZiKQo+ICsJCXJldHVybjsKPiArCj4gKwlnZW1fb2JqID0gZHJtX2dlbV9mYl9nZXRfb2Jq KG9sZF9zdGF0ZS0+ZmIsIDApOwo+ICsJdmttc19nZW1fdnVubWFwKGdlbV9vYmopOwo+ICt9Cj4g Kwo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9oZWxwZXJfZnVuY3Mgdmttc19wcmlt YXJ5X2hlbHBlcl9mdW5jcyA9IHsKPiAgCS5hdG9taWNfdXBkYXRlCQk9IHZrbXNfcHJpbWFyeV9w bGFuZV91cGRhdGUsCj4gKwkucHJlcGFyZV9mYgkJPSB2a21zX3ByZXBhcmVfZmIsCj4gKwkuY2xl YW51cF9mYgkJPSB2a21zX2NsZWFudXBfZmIsCj4gIH07Cj4gIAo+ICBzdHJ1Y3QgZHJtX3BsYW5l ICp2a21zX3BsYW5lX2luaXQoc3RydWN0IHZrbXNfZGV2aWNlICp2a21zZGV2KQo+IC0tIAo+IDIu MTcuMQo+IAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9t aXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=