From: Eduardo Habkost <ehabkost@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] opts: remove redundant check for NULL parameter
Date: Mon, 16 Jul 2018 18:28:21 -0300 [thread overview]
Message-ID: <20180716212821.GT914@localhost.localdomain> (raw)
In-Reply-To: <20180514171913.17664-4-berrange@redhat.com>
On Mon, May 14, 2018 at 06:19:13PM +0100, Daniel P. Berrangé wrote:
> No callers of get_opt_value() pass in a NULL for the "value" parameter,
> so the check is redundant.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Queueing on x86-next.
--
Eduardo
next prev parent reply other threads:[~2018-07-16 21:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 17:19 [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules Daniel P. Berrangé
2018-05-14 17:19 ` [Qemu-devel] [PATCH 1/3] i386: fix regression parsing multiboot initrd modules Daniel P. Berrangé
2018-05-18 17:54 ` Peter Maydell
2018-05-21 8:56 ` Daniel P. Berrangé
2018-07-16 21:23 ` Eduardo Habkost
2018-05-14 17:19 ` [Qemu-devel] [PATCH 2/3] i386: only parse the initrd_filename once for multiboot modules Daniel P. Berrangé
2018-07-16 21:28 ` Eduardo Habkost
2018-05-14 17:19 ` [Qemu-devel] [PATCH 3/3] opts: remove redundant check for NULL parameter Daniel P. Berrangé
2018-07-16 21:28 ` Eduardo Habkost [this message]
2018-06-07 9:47 ` [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules Daniel P. Berrangé
2018-07-10 17:11 ` Roman Kagan
2018-07-10 17:23 ` Eduardo Habkost
2018-08-16 14:34 ` Roman Kagan
2018-08-16 14:38 ` Daniel P. Berrangé
2018-08-16 14:41 ` Roman Kagan
2018-06-20 14:57 ` Roman Kagan
2018-06-20 15:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716212821.GT914@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.