All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: daniel.lezcano@linaro.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, aford173@gmail.com,
	drivshin@awxrd.com
Subject: Re: [RFC PATCH 1/4] ARM: dts: am33xx: Add all fck timer clocks
Date: Mon, 16 Jul 2018 22:55:47 -0700	[thread overview]
Message-ID: <20180717055547.GV99251@atomide.com> (raw)
In-Reply-To: <1531773542-15736-2-git-send-email-narmstrong@baylibre.com>

Hi,

* Neil Armstrong <narmstrong@baylibre.com> [180716 20:42]:
> Add the missing fck clock to all timer nodes of the AM33XX dtsi.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm/boot/dts/am33xx.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 9cd62bc2..e8e665d 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -541,6 +541,8 @@
>  			reg = <0x48042000 0x400>;
>  			interrupts = <69>;
>  			ti,hwmods = "timer3";
> +			clocks = <&timer3_fck>;
> +			clock-names = "fck";
>  		};

These should all use the clkctrl clock nodes, see:

$ git grep CLKCTRL include/dt-bindings/clock/ | grep TIMER

The module clock is bit 0, and on some SoCs bit 24 is the
timer fck. But I don't think these SoS use separate bit 24
clock.

Regards,

Tony

  reply	other threads:[~2018-07-17  5:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 20:38 [RFC PATCH 0/4] Fix dmtimer parent clock setup Neil Armstrong
2018-07-16 20:38 ` [RFC PATCH 1/4] ARM: dts: am33xx: Add all fck timer clocks Neil Armstrong
2018-07-17  5:55   ` Tony Lindgren [this message]
2018-07-17 20:28     ` Neil Armstrong
2018-07-19  6:42       ` Tony Lindgren
2018-07-16 20:39 ` [RFC PATCH 2/4] ARM: dts: am4372: " Neil Armstrong
2018-07-16 20:39 ` [RFC PATCH 3/4] ARM: dts: dm816x: " Neil Armstrong
2018-07-16 20:39 ` [RFC PATCH 4/4] timer-ti-dm: Fix omap_dm_timer_of_set_source() Neil Armstrong
2018-07-16 23:21 ` [RFC PATCH 0/4] Fix dmtimer parent clock setup David Rivshin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717055547.GV99251@atomide.com \
    --to=tony@atomide.com \
    --cc=aford173@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=drivshin@awxrd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.