From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [Nouveau] [PATCH 2/5] drm/nouveau: Grab RPM ref while probing outputs Date: Tue, 17 Jul 2018 09:21:52 +0200 Message-ID: <20180717072152.GA16115@wunner.de> References: <20180716235936.11268-1-lyude@redhat.com> <20180716235936.11268-3-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180716235936.11268-3-lyude@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lyude Paul Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs List-Id: nouveau.vger.kernel.org T24gTW9uLCBKdWwgMTYsIDIwMTggYXQgMDc6NTk6MjZQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNwbnY1MC9kaXNwLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNwbnY1MC9kaXNwLmMKPiBAQCAtMjAxMiwxMCAr MjAxMiwxOCBAQCBudjUwX2Rpc3BfYXRvbWljX3N0YXRlX2FsbG9jKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4gIAlyZXR1cm4gJmF0b20tPnN0YXRlOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZAo+ ICtub3V2ZWF1X291dHB1dF9wb2xsX2NoYW5nZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAr ewo+ICsJcG1fcnVudGltZV9nZXRfc3luYyhkZXYtPmRldik7Cj4gKwlkcm1fZmJfaGVscGVyX2hv dHBsdWdfZXZlbnQoZGV2LT5mYl9oZWxwZXIpOwo+ICsJcG1fcnVudGltZV9wdXRfYXV0b3N1c3Bl bmQoZGV2LT5kZXYpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2Nv bmZpZ19mdW5jcwo+ICBudjUwX2Rpc3BfZnVuYyA9IHsKPiAgCS5mYl9jcmVhdGUgPSBub3V2ZWF1 X3VzZXJfZnJhbWVidWZmZXJfY3JlYXRlLAo+IC0JLm91dHB1dF9wb2xsX2NoYW5nZWQgPSBkcm1f ZmJfaGVscGVyX291dHB1dF9wb2xsX2NoYW5nZWQsCj4gKwkub3V0cHV0X3BvbGxfY2hhbmdlZCA9 IG5vdXZlYXVfb3V0cHV0X3BvbGxfY2hhbmdlZCwKCkl0IG1pZ2h0IG1ha2Ugc2Vuc2UgdG8gcHJv dmlkZSBhIGdlbmVyaWMgRFJNIGhlbHBlciBmb3IgdGhpcy4KU2FtZSBmb3IgcGF0Y2ggMyBpbiB0 aGlzIHNlcmllcy4KClRoYW5rcywKCkx1a2FzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A89ECDFB3 for ; Tue, 17 Jul 2018 07:21:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAB2120863 for ; Tue, 17 Jul 2018 07:21:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAB2120863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729063AbeGQHxF (ORCPT ); Tue, 17 Jul 2018 03:53:05 -0400 Received: from bmailout2.hostsharing.net ([83.223.90.240]:34871 "EHLO bmailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728024AbeGQHxF (ORCPT ); Tue, 17 Jul 2018 03:53:05 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 449BA2801FAD2; Tue, 17 Jul 2018 09:21:53 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id DB85822684B; Tue, 17 Jul 2018 09:21:52 +0200 (CEST) Date: Tue, 17 Jul 2018 09:21:52 +0200 From: Lukas Wunner To: Lyude Paul Cc: nouveau@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Maarten Lankhorst , linux-kernel@vger.kernel.org, Ben Skeggs , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Nouveau] [PATCH 2/5] drm/nouveau: Grab RPM ref while probing outputs Message-ID: <20180717072152.GA16115@wunner.de> References: <20180716235936.11268-1-lyude@redhat.com> <20180716235936.11268-3-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180716235936.11268-3-lyude@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 16, 2018 at 07:59:26PM -0400, Lyude Paul wrote: > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -2012,10 +2012,18 @@ nv50_disp_atomic_state_alloc(struct drm_device *dev) > return &atom->state; > } > > +static void > +nouveau_output_poll_changed(struct drm_device *dev) > +{ > + pm_runtime_get_sync(dev->dev); > + drm_fb_helper_hotplug_event(dev->fb_helper); > + pm_runtime_put_autosuspend(dev->dev); > +} > + > static const struct drm_mode_config_funcs > nv50_disp_func = { > .fb_create = nouveau_user_framebuffer_create, > - .output_poll_changed = drm_fb_helper_output_poll_changed, > + .output_poll_changed = nouveau_output_poll_changed, It might make sense to provide a generic DRM helper for this. Same for patch 3 in this series. Thanks, Lukas