Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Jul 17, 2018 at 01:33:38PM +0200, Juan Quintela wrote:
> If you don't want to compile everything, you configure
> config-devices.mak.  And then make clean remove it, and make will
> create a default one without your configuration.  Fix it by not
> removing it.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 2da686be33..2ffbcde323 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -751,7 +751,7 @@ clean:
>  	if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
>  	rm -f $$d/qemu-options.def; \
>          done
> -	rm -f $(SUBDIR_DEVICES_MAK) config-all-devices.mak
> +	rm -f config-all-devices.mak
>  
>  VERSION ?= $(shell cat VERSION)

This feels wrong to me.  If 'make' is creating config-devices.mak, then
either 'make clean' or 'make distclean' must remove it. So if you remove
it here, it should be added to distclean instead.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|