From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 17 Jul 2018 09:21:39 -0400 Subject: [U-Boot] [PATCH v2] serial: ns16550: Add register shift variable In-Reply-To: <4881796E12491D4BB15146FE0209CE64681150DE@DE02WEMBXB.internal.synopsys.com> References: <1531810943-3417-1-git-send-email-fb@ltec.ch> <73fa69c3-552b-e1d9-bbbf-2825a0b9c5ca@ti.com> <2e208e94-a428-fe7f-0e7c-4ee288904d3d@ti.com> <34d48d02-901f-56de-a12f-636eaa2068b2@suse.de> <5666d5b8-8dda-0e12-a567-50b9599432e1@ltec.ch> <4881796E12491D4BB15146FE0209CE64681150DE@DE02WEMBXB.internal.synopsys.com> Message-ID: <20180717132139.GA10857@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jul 17, 2018 at 12:45:51PM +0000, Alexey Brodkin wrote: > Hi Felix, > > > -----Original Message----- > > From: Felix Brack [mailto:fb at ltec.ch] > > Sent: Tuesday, July 17, 2018 3:13 PM > > To: Alexander Graf ; Lokesh Vutla ; u-boot at lists.denx.de > > Cc: Wolfgang Denk ; Tom Rini ; Marek Vasut ; Patrice Chotard > > ; Michal Simek ; Simon Glass ; Alexey Brodkin > > ; Bin Meng ; Ley Foon Tan ; Patrick Delaunay > > ; Mario Six ; Stefan Roese ; Bernhard Messerklinger > > > > Subject: Re: [PATCH v2] serial: ns16550: Add register shift variable > > [snip] > > > Adding a separate PORT in ns16550_serial_ids for a particular > > architecture, platform or SoC would be an option. However the patch I > > posted is much more generic as it offers to set the reg-shift property > > for no matter what architecture, platform or SoC. It can also easily be > > extended by adding more conditional defaults to the Kconfig file. > > I'd say we're dealing with just one corner-case here. > If I understand a concept of Device Tree it is supposed to describe your > hardware. Thus if reg shift exists in your HW it should be explicitly mentioned in > your .dts. If for some [historical] reason you have to deal with "incorrect" .dts then > I'd prefer to have mentioned quirk with a separate PORT in ns16550_serial_ids > instead of adding yet another Kconfig option. So, this is part of the problem I suppose. I don't know _why_ we can't just add the correct and valid reg-shift property to the dtsi file in Linux and be done with it. Then the U-Boot driver would work because we parse that property. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: