From: Christoph Hellwig <hch@infradead.org>
To: Shunyong Yang <shunyong.yang@hxt-semitech.com>
Cc: bhelgaas@google.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Joey Zheng <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH] PCI: Unify pci and normal dma direction definition
Date: Tue, 17 Jul 2018 07:03:35 -0700 [thread overview]
Message-ID: <20180717140335.GA23500@infradead.org> (raw)
In-Reply-To: <1531463840-34651-1-git-send-email-shunyong.yang@hxt-semitech.com>
> diff --git a/include/linux/dma-direction.h b/include/linux/dma-direction.h
> index 3649a031893a..9d52716e9218 100644
> --- a/include/linux/dma-direction.h
> +++ b/include/linux/dma-direction.h
> @@ -2,7 +2,7 @@
> #ifndef _LINUX_DMA_DIRECTION_H
> #define _LINUX_DMA_DIRECTION_H
> /*
> - * These definitions mirror those in pci.h, so they can be used
> + * These definitions mirror those in pci-dma-compat.h, so they can be used
> * interchangeably with their PCI_ counterparts.
> */
I think we can just drop this comment anymore.
> +#define PCI_DMA_BIDIRECTIONAL (DMA_BIDIRECTIONAL)
> +#define PCI_DMA_TODEVICE (DMA_TO_DEVICE)
> +#define PCI_DMA_FROMDEVICE (DMA_FROM_DEVICE)
> +#define PCI_DMA_NONE (DMA_NONE)
No need for the braces.
next prev parent reply other threads:[~2018-07-17 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 6:37 [PATCH] PCI: Unify pci and normal dma direction definition Shunyong Yang
2018-07-17 14:03 ` Christoph Hellwig [this message]
2018-07-18 0:45 ` Yang, Shunyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717140335.GA23500@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shunyong.yang@hxt-semitech.com \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.