Re: [PATCH 3/3] drm/i915: Remove intel_panel_detect()

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Jul 17, 2018 at 08:42:16PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> With neither LVDS or eDP no longer using intel_panel_detect() we can
> kill it, and the accompanying modparam.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

supposing that patch 2/3 goes through,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>



> ---
>  drivers/gpu/drm/i915/i915_params.c |  4 ----
>  drivers/gpu/drm/i915/i915_params.h |  1 -
>  drivers/gpu/drm/i915/intel_drv.h   |  1 -
>  drivers/gpu/drm/i915/intel_panel.c | 20 --------------------
>  4 files changed, 26 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 817576701ed7..295e981e4a39 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -44,10 +44,6 @@ i915_param_named(modeset, int, 0400,
>  	"Use kernel modesetting [KMS] (0=disable, "
>  	"1=on, -1=force vga console preference [default])");
>  
> -i915_param_named_unsafe(panel_ignore_lid, int, 0600,
> -	"Override lid status (0=autodetect, 1=autodetect disabled [default], "
> -	"-1=force lid closed, -2=force lid open)");
> -
>  i915_param_named_unsafe(enable_dc, int, 0400,
>  	"Enable power-saving display C-states. "
>  	"(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6)");
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index aebe0469ddaa..6c4d4a21474b 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -36,7 +36,6 @@ struct drm_printer;
>  #define I915_PARAMS_FOR_EACH(param) \
>  	param(char *, vbt_firmware, NULL) \
>  	param(int, modeset, -1) \
> -	param(int, panel_ignore_lid, 1) \
>  	param(int, lvds_channel_mode, 0) \
>  	param(int, panel_use_ssc, -1) \
>  	param(int, vbt_sdvo_panel_type, -1) \
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 794d7b05a8b0..94ec8fa89edf 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1892,7 +1892,6 @@ void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
>  				  const struct drm_connector_state *conn_state);
>  void intel_panel_disable_backlight(const struct drm_connector_state *old_conn_state);
>  void intel_panel_destroy_backlight(struct drm_connector *connector);
> -enum drm_connector_status intel_panel_detect(struct drm_i915_private *dev_priv);
>  extern struct drm_display_mode *intel_find_panel_downclock(
>  				struct drm_i915_private *dev_priv,
>  				struct drm_display_mode *fixed_mode,
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index 14b827ec5427..4a9f139e7b73 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -375,26 +375,6 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc,
>  	pipe_config->gmch_pfit.lvds_border_bits = border;
>  }
>  
> -enum drm_connector_status
> -intel_panel_detect(struct drm_i915_private *dev_priv)
> -{
> -	/* Assume that the BIOS does not lie through the OpRegion... */
> -	if (!i915_modparams.panel_ignore_lid && dev_priv->opregion.lid_state) {
> -		return *dev_priv->opregion.lid_state & 0x1 ?
> -			connector_status_connected :
> -			connector_status_disconnected;
> -	}
> -
> -	switch (i915_modparams.panel_ignore_lid) {
> -	case -2:
> -		return connector_status_connected;
> -	case -1:
> -		return connector_status_disconnected;
> -	default:
> -		return connector_status_unknown;
> -	}
> -}
> -
>  /**
>   * scale - scale values from one range to another
>   * @source_val: value in range [@source_min..@source_max]
> -- 
> 2.16.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx