From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC v1 2/2] libdrm: change to meson build system
Date: Tue, 17 Jul 2018 21:14:30 +0200 [thread overview]
Message-ID: <20180717211430.74ac99ef@gmx.net> (raw)
In-Reply-To: <fqht1fxpqg.ln2@ID-313208.user.individual.net>
Hello Bernd,
On Mon, 16 Jul 2018 05:59:43 +0200, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Am Fri, 13 Jul 2018 22:58:01 +0200 schrieb Peter Seiderer:
>
> > --- a/package/libdrm/libdrm.mk
> > +++ b/package/libdrm/libdrm.mk
> [..]
> > -$(eval $(autotools-package))
> > +$(eval $(meson-package))
>
> Hi Peter,
>
> last year I sent a patch to switch libpng from autotools to cmake:
> http://lists.busybox.net/pipermail/buildroot/2017-September/201303.html
>
> The patch was rejected by Yann
> http://lists.busybox.net/pipermail/buildroot/2017-September/201305.html
>
> > If upstream has changed, or there is a *compelling* reason to switch,
> > then so be it. In this case, the commit log *must* explain the rationale
> > for switching.
> >
> > But switching for the sake of switching is a big no-no from me.
>
> and Thomas
> http://lists.busybox.net/pipermail/buildroot/2017-September/201307.html
>
> > I agree that there needs to be an explanation for the switch. Is
> > upstream moving to CMake, and getting rid of autotools support in the
> > future ? Other reason ?
>
> From the current discussion of your RFC I am unable to see the
> "*compelling* reason" for using meson. Instead the mess around python2/
> python3 imho does not justify the few seconds libdrm itself will build
> faster, so NACK.
....thats one of the reasons I send the patch set as RFC ;-), but the
long term hope would be that the conversion of enough packages will
give more time saving than the additonal python/python3/meson/ninja
build-time...
Converting libdrm was by random choice (I knew it has meson build
enabled and the options where simple enough)...
libinput is one of the packages which switched exclusivly to meson (since 1.9.x)
and GStreamer folks are pushing the conversion to meson to gain
VisualStudio compiles on Windows (and because of the build-time saving)...
Regards,
Peter
>
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2018-07-17 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 20:58 [Buildroot] [RFC v1 1/2] meson: change from global to per package cross-compilation.conf Peter Seiderer
2018-07-13 20:58 ` [Buildroot] [RFC v1 2/2] libdrm: change to meson build system Peter Seiderer
2018-07-14 20:27 ` Thomas Petazzoni
2018-07-14 20:31 ` Thomas Petazzoni
2018-07-15 10:02 ` Eric Le Bihan
2018-07-15 14:31 ` Thomas Petazzoni
2018-07-15 19:19 ` Peter Seiderer
2018-07-15 19:02 ` Peter Seiderer
2018-07-15 20:55 ` Peter Seiderer
2018-07-16 3:59 ` Bernd Kuhls
2018-07-16 8:35 ` Thomas Petazzoni
2018-07-17 19:14 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717211430.74ac99ef@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.