All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Protsenko <semen.protsenko@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 1/2] env: Drop error messages when loading environment
Date: Wed, 18 Jul 2018 01:09:11 +0300	[thread overview]
Message-ID: <20180717220912.11358-1-semen.protsenko@linaro.org> (raw)

This is just a draft to discuss ideas related to "Make U-Boot log great
again" thread.

With this patch we will have something like this:

    Loading Environment from FAT... Failed (-5)
    Loading Environment from MMC... OK

instead of this:

    Loading Environment from FAT... MMC: no card present
    ** Bad device mmc 0 **
    Failed (-5)
    Loading Environment from MMC... OK

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 env/env.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/env/env.c b/env/env.c
index 5c0842ac07..85598fa5d4 100644
--- a/env/env.c
+++ b/env/env.c
@@ -187,6 +187,7 @@ int env_load(void)
 
 	for (prio = 0; (drv = env_driver_lookup(ENVOP_LOAD, prio)); prio++) {
 		int ret;
+		unsigned long have_console = gd->have_console;
 
 		if (!drv->load)
 			continue;
@@ -195,7 +196,11 @@ int env_load(void)
 			continue;
 
 		printf("Loading Environment from %s... ", drv->name);
+
+		/* Suppress console output for drv->load() */
+		gd->have_console = 0;
 		ret = drv->load();
+		gd->have_console = have_console;
 		if (ret)
 			printf("Failed (%d)\n", ret);
 		else
-- 
2.18.0

             reply	other threads:[~2018-07-17 22:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 22:09 Sam Protsenko [this message]
2018-07-17 22:09 ` [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env Sam Protsenko
2018-07-18  6:23   ` Wolfgang Denk
2018-07-18 12:53   ` Tom Rini
2018-07-18 13:04     ` Sam Protsenko
2018-07-18 14:28       ` Tom Rini
2018-07-18 14:09     ` Wolfgang Denk
2018-07-19 12:52       ` Tom Rini
2018-07-19 13:12         ` Sam Protsenko
2018-07-19 19:52           ` Wolfgang Denk
2018-07-19 20:16             ` Sam Protsenko
2018-07-19 19:49         ` Wolfgang Denk
2018-07-18  6:19 ` [U-Boot] [RFC 1/2] env: Drop error messages when loading environment Wolfgang Denk
2018-07-18 12:50   ` Sam Protsenko
2018-07-18 12:51   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717220912.11358-1-semen.protsenko@linaro.org \
    --to=semen.protsenko@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.