From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dvb usb issues since kernel 4.9 From: Mauro Carvalho Chehab Message-Id: <20180718072107.0bfdece8@vela.lan> Date: Wed, 18 Jul 2018 07:21:07 +0900 To: Linus Torvalds Cc: hannah@marvell.com, Jonathan Corbet , David Miller , Eric Dumazet , Greg Kroah-Hartman , Josef Griebichler , Hannes Frederic Sowa , Jesper Dangaard Brouer , Linux Kernel Mailing List , Linux Media Mailing List , USB list , Mauro Carvalho Chehab , Ingo Molnar , Network Development , Paolo Abeni , Peter Zijlstra , Rik van Riel , Alan Stern , dma , vkoul@kernel.org, Dan Williams , nadavh@marvell.com, thomas.petazzoni@bootlin.com, omrii@marvell.com List-ID: SGkgTGludXMsCgpFbSBUdWUsIDE3IEp1bCAyMDE4IDEwOjA5OjI4IC0wNzAwCkxpbnVzIFRvcnZh bGRzIDx0b3J2YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4gZXNjcmV2ZXU6Cgo+IE9uIFR1ZSwg SnVsIDE3LCAyMDE4IGF0IDQ6NTggQU0gSGFubmEgSGF3YSA8aGFubmFoQG1hcnZlbGwuY29tPiB3 cm90ZToKPiA+Cj4gPiBBZnRlciBzb21lIGRlYnVnL2Jpc2VjdC9kaWZmLCBmb3VuZCB0aGF0IHBh dGNoICJzb2Z0aXJxOiBMZXQga3NvZnRpcnFkCj4gPiBkbyBpdHMgam9iIiBpcyBwcm9ibGVtYXRp YyBwYXRjaC4gIAo+IAo+IE9rLCB0aGlzIHRocmVhZCBkaWVkIGRvd24gd2l0aG91dCBhbnkgcmVz b2x1dGlvbi4KPiAKPiA+LSBVc2luZyB2NC4xNC4wIChpbmNsdWRpbmcgc29mdGlycSBwYXRjaCkg YW5kIHRoZSBhZGRpdGlvbmFsIGZpeAo+ID4gcHJvcG9zZWQgYnkgTGludXMgLSBubyB0aW1lb3V0 IGlzc3VlLiAgCj4gCj4gQXJlIHlvdSB0YWxraW5nIGFib3V0IHRoZSBwYXRjaCB0aGF0IG1hZGUg SElfU09GVElSUSBhbmQKPiBUQVNLTEVUX1NPRlRJUlEgc3BlY2lhbCwgYW5kIGhhZCB0aGlzOgo+ IAo+ICAgI2RlZmluZSBTT0ZUSVJRX05PV19NQVNLICgoMSA8PCBISV9TT0ZUSVJRKSB8ICgxIDw8 IFRBU0tMRVRfU09GVElSUSkpCj4gCj4gaW4gaXQ/Cj4gCj4gSSB0aGluayBJJ2xsIGp1c3QgY29t bWl0IHRoZSBkYW1uIHRoaW5nLiBJdCdzIGhhY2t5LCBidXQgaXQncyBzaW1wbGUsCj4gYW5kIGl0 IG5ldmVyIGdvdCBhcHBsaWVkIGJlY2F1c2Ugd2UgaGFkIHNtYXJ0ZXIgc3VnZ2VzdGlvbnMuIEJ1 dCB0aGUKPiBzbWFydGVyIHN1Z2dlc3Rpb25zIG5ldmVyIGVuZGVkIHVwIGJlaW5nIGFwcGxpZWQg ZWl0aGVyLCBzby4uCgpZZWFoLCBJTUhPIHRoZSBiZXN0IHdvdWxkIGJlIHRvIGFwcGx5IHlvdXIg cGF0Y2hbMV0sIGMvYyBzdGFibGUgdXAgdG8KNC45LiBOb3RoaW5nIHByZXZlbnRzIGFwcGx5aW5n IGEgYmV0dGVyL3NtYXJ0ZXIgc29sdXRpb24gb25jZSB3ZQpoYXZlIGl0LiBGcm9tIG15IHNpZGUs IEkgY2FuIGtlZXAgdGVzdGluZyB3aGF0ZXZlciBzbWFydCBzdWdnZXN0aW9ucwpwZW9wbGUgcHJv cG9zZS4gWWV0LCBiZXR0ZXIgdG8gaGF2ZSBvbmUgZml4IG9uIG91ciBoYW5kIHRoYW4gdHdvCmZp eGVzIGZseWluZyBhcm91bmQuCgpbMV0gZS4gZy4gCglodHRwczovL2dpdC5saW51eHR2Lm9yZy9t Y2hlaGFiL2V4cGVyaW1lbnRhbC5naXQvY29tbWl0Lz9oPXY0LjE1JTJibWVkaWElMmJkd2MyJmlk PWNjZjgzM2ZkNGE1Yjk5YzNkM2NmMmMwOWMwNjU2NzBmNzRhMjMwYTcKClJlZ2FyZHMsCk1hdXJv Ci0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJz Y3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZn ZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwu b3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:49242 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729741AbeGQW4J (ORCPT ); Tue, 17 Jul 2018 18:56:09 -0400 Date: Wed, 18 Jul 2018 07:21:07 +0900 From: Mauro Carvalho Chehab To: Linus Torvalds Cc: hannah@marvell.com, Jonathan Corbet , David Miller , Eric Dumazet , Greg Kroah-Hartman , Josef Griebichler , Hannes Frederic Sowa , Jesper Dangaard Brouer , Linux Kernel Mailing List , Linux Media Mailing List , USB list , Mauro Carvalho Chehab , Ingo Molnar , Network Development , Paolo Abeni , Peter Zijlstra , Rik van Riel , Alan Stern , dma , vkoul@kernel.org, Dan Williams , nadavh@marvell.com, thomas.petazzoni@bootlin.com, omrii@marvell.com Subject: Re: dvb usb issues since kernel 4.9 Message-ID: <20180718072107.0bfdece8@vela.lan> In-Reply-To: References: <1d3d0fe3-bc02-7720-15ac-6bc06e00067c@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Linus, Em Tue, 17 Jul 2018 10:09:28 -0700 Linus Torvalds escreveu: > On Tue, Jul 17, 2018 at 4:58 AM Hanna Hawa wrote: > > > > After some debug/bisect/diff, found that patch "softirq: Let ksoftirqd > > do its job" is problematic patch. > > Ok, this thread died down without any resolution. > > >- Using v4.14.0 (including softirq patch) and the additional fix > > proposed by Linus - no timeout issue. > > Are you talking about the patch that made HI_SOFTIRQ and > TASKLET_SOFTIRQ special, and had this: > > #define SOFTIRQ_NOW_MASK ((1 << HI_SOFTIRQ) | (1 << TASKLET_SOFTIRQ)) > > in it? > > I think I'll just commit the damn thing. It's hacky, but it's simple, > and it never got applied because we had smarter suggestions. But the > smarter suggestions never ended up being applied either, so.. Yeah, IMHO the best would be to apply your patch[1], c/c stable up to 4.9. Nothing prevents applying a better/smarter solution once we have it. From my side, I can keep testing whatever smart suggestions people propose. Yet, better to have one fix on our hand than two fixes flying around. [1] e. g. https://git.linuxtv.org/mchehab/experimental.git/commit/?h=v4.15%2bmedia%2bdwc2&id=ccf833fd4a5b99c3d3cf2c09c065670f74a230a7 Regards, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: dvb usb issues since kernel 4.9 Date: Wed, 18 Jul 2018 07:21:07 +0900 Message-ID: <20180718072107.0bfdece8@vela.lan> References: <1d3d0fe3-bc02-7720-15ac-6bc06e00067c@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: hannah@marvell.com, Jonathan Corbet , David Miller , Eric Dumazet , Greg Kroah-Hartman , Josef Griebichler , Hannes Frederic Sowa , Jesper Dangaard Brouer , Linux Kernel Mailing List , Linux Media Mailing List , USB list , Mauro Carvalho Chehab , Ingo Molnar , Network Development , Paolo Abeni , Peter Zijlstra , Rik van Riel , Alan Stern , dma Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:49242 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729741AbeGQW4J (ORCPT ); Tue, 17 Jul 2018 18:56:09 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hi Linus, Em Tue, 17 Jul 2018 10:09:28 -0700 Linus Torvalds escreveu: > On Tue, Jul 17, 2018 at 4:58 AM Hanna Hawa wrote: > > > > After some debug/bisect/diff, found that patch "softirq: Let ksoftirqd > > do its job" is problematic patch. > > Ok, this thread died down without any resolution. > > >- Using v4.14.0 (including softirq patch) and the additional fix > > proposed by Linus - no timeout issue. > > Are you talking about the patch that made HI_SOFTIRQ and > TASKLET_SOFTIRQ special, and had this: > > #define SOFTIRQ_NOW_MASK ((1 << HI_SOFTIRQ) | (1 << TASKLET_SOFTIRQ)) > > in it? > > I think I'll just commit the damn thing. It's hacky, but it's simple, > and it never got applied because we had smarter suggestions. But the > smarter suggestions never ended up being applied either, so.. Yeah, IMHO the best would be to apply your patch[1], c/c stable up to 4.9. Nothing prevents applying a better/smarter solution once we have it. From my side, I can keep testing whatever smart suggestions people propose. Yet, better to have one fix on our hand than two fixes flying around. [1] e. g. https://git.linuxtv.org/mchehab/experimental.git/commit/?h=v4.15%2bmedia%2bdwc2&id=ccf833fd4a5b99c3d3cf2c09c065670f74a230a7 Regards, Mauro