diff for duplicates of <20180718081252.GC4641@dell> diff --git a/a/1.txt b/N1/1.txt index 4c89ff0..7ce69ef 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -40,7 +40,7 @@ On Wed, 18 Jul 2018, Lee Jones wrote: > > - */ > > - if (num_steps) { > > + if ((of_property_read_u32(node, "num-interpolated-steps", -> > + &num_steps) = 0) && num_steps) { +> > + &num_steps) == 0) && num_steps) { > > This is pretty ugly, and isn't it suffering from over-bracketing? My > suggestion would be to break out the invocation of @@ -83,3 +83,7 @@ Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N1/content_digest index 146ffb7..1c2039f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020180718080913.GB4641@dell\0" "From\0Lee Jones <lee.jones@linaro.org>\0" "Subject\0Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable\0" - "Date\0Wed, 18 Jul 2018 08:12:52 +0000\0" + "Date\0Wed, 18 Jul 2018 09:12:52 +0100\0" "To\0Daniel Thompson <daniel.thompson@linaro.org>\0" "Cc\0linux-pwm@vger.kernel.org" linux-fbdev@vger.kernel.org @@ -57,7 +57,7 @@ "> > -\t\t */\n" "> > -\t\tif (num_steps) {\n" "> > +\t\tif ((of_property_read_u32(node, \"num-interpolated-steps\",\n" - "> > +\t\t\t\t\t &num_steps) = 0) && num_steps) {\n" + "> > +\t\t\t\t\t &num_steps) == 0) && num_steps) {\n" "> \n" "> This is pretty ugly, and isn't it suffering from over-bracketing? My\n" "> suggestion would be to break out the invocation of\n" @@ -99,6 +99,10 @@ "Lee Jones [\346\235\216\347\220\274\346\226\257]\n" "Linaro Services Technical Lead\n" "Linaro.org \342\224\202 Open source software for ARM SoCs\n" - Follow Linaro: Facebook | Twitter | Blog + "Follow Linaro: Facebook | Twitter | Blog\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -48e2ffbf6125e717fe12ba2cfc2f0ec907f2644ff13659f0a996f2ec3fa97756 +32f84c9096a1608259ee49d613b5e1f0cf7f164b2ed09e363731ff5ef98dc047
diff --git a/a/1.txt b/N2/1.txt index 4c89ff0..e4a5d2b 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -40,7 +40,7 @@ On Wed, 18 Jul 2018, Lee Jones wrote: > > - */ > > - if (num_steps) { > > + if ((of_property_read_u32(node, "num-interpolated-steps", -> > + &num_steps) = 0) && num_steps) { +> > + &num_steps) == 0) && num_steps) { > > This is pretty ugly, and isn't it suffering from over-bracketing? My > suggestion would be to break out the invocation of diff --git a/a/content_digest b/N2/content_digest index 146ffb7..e5a9970 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,17 +2,17 @@ "ref\020180718080913.GB4641@dell\0" "From\0Lee Jones <lee.jones@linaro.org>\0" "Subject\0Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable\0" - "Date\0Wed, 18 Jul 2018 08:12:52 +0000\0" + "Date\0Wed, 18 Jul 2018 09:12:52 +0100\0" "To\0Daniel Thompson <daniel.thompson@linaro.org>\0" - "Cc\0linux-pwm@vger.kernel.org" - linux-fbdev@vger.kernel.org + "Cc\0Jingoo Han <jingoohan1@gmail.com>" + Thierry Reding <thierry.reding@gmail.com> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - Marcel Ziswiler <marcel.ziswiler@toradex.com> - Jingoo Han <jingoohan1@gmail.com> - patches@linaro.org - linux-kernel@vger.kernel.org + linux-pwm@vger.kernel.org dri-devel@lists.freedesktop.org - " Thierry Reding <thierry.reding@gmail.com>\0" + linux-fbdev@vger.kernel.org + linux-kernel@vger.kernel.org + patches@linaro.org + " Marcel Ziswiler <marcel.ziswiler@toradex.com>\0" "\00:1\0" "b\0" "On Wed, 18 Jul 2018, Lee Jones wrote:\n" @@ -57,7 +57,7 @@ "> > -\t\t */\n" "> > -\t\tif (num_steps) {\n" "> > +\t\tif ((of_property_read_u32(node, \"num-interpolated-steps\",\n" - "> > +\t\t\t\t\t &num_steps) = 0) && num_steps) {\n" + "> > +\t\t\t\t\t &num_steps) == 0) && num_steps) {\n" "> \n" "> This is pretty ugly, and isn't it suffering from over-bracketing? My\n" "> suggestion would be to break out the invocation of\n" @@ -101,4 +101,4 @@ "Linaro.org \342\224\202 Open source software for ARM SoCs\n" Follow Linaro: Facebook | Twitter | Blog -48e2ffbf6125e717fe12ba2cfc2f0ec907f2644ff13659f0a996f2ec3fa97756 +d4b9ab0abb3f0bf98b79598d66221f85ed984e61d98e7e1ac95beccf7298231a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.