From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: keescook@chromium.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, s.mesoraca16@gmail.com,
f.fainelli@gmail.com, David.Laight@aculab.com
Subject: Re: [PATCH v2] net: dsa: Remove VLA usage
Date: Wed, 18 Jul 2018 22:37:25 +0200 [thread overview]
Message-ID: <20180718203725.GD20228@lunn.ch> (raw)
In-Reply-To: <20180719.053333.396851874410198344.davem@davemloft.net>
On Thu, Jul 19, 2018 at 05:33:33AM +0900, David Miller wrote:
> From: Kees Cook <keescook@chromium.org>
> Date: Mon, 16 Jul 2018 21:10:34 -0700
>
> > From: Salvatore Mesoraca <s.mesoraca16@gmail.com>
> >
> > We avoid 2 VLAs by using a pre-allocated field in dsa_switch. We also
> > try to avoid dynamic allocation whenever possible (when using fewer than
> > bits-per-long ports, which is the common case).
> >
> > Link: http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> > Link: http://lkml.kernel.org/r/20180505185145.GB32630@lunn.ch
> > Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
> > [kees: tweak commit subject and message slightly]
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Florian and Andrew, please review.
Last time there was some discussion of just always allocating it to
make the code simpler. But the extra complexity is O.K.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-07-18 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 4:10 [PATCH v2] net: dsa: Remove VLA usage Kees Cook
2018-07-18 20:33 ` David Miller
2018-07-18 20:37 ` Andrew Lunn [this message]
2018-07-18 22:08 ` David Miller
2018-07-29 11:38 ` Pavel Machek
2018-07-29 11:40 ` Pavel Machek
2018-07-30 8:59 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718203725.GD20228@lunn.ch \
--to=andrew@lunn.ch \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.mesoraca16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.