From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lyude Paul <lyude@redhat.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro
Date: Wed, 18 Jul 2018 16:07:05 -0700 [thread overview]
Message-ID: <20180718230705.GD2146@intel.com> (raw)
In-Reply-To: <20180718215716.5784-1-lyude@redhat.com>
On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote:
> This isn't supposed to take dev as an argument, I guess no one noticed!
Apparently no one using it... Why don't we just kill it?
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
anyways, if you prefer to keep or have plans to use:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> include/drm/drm_print.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index 767c90b654c5..fc08584a5101 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -310,7 +310,7 @@ void drm_err(const char *format, ...);
>
> #define DRM_DEV_DEBUG_DP(dev, fmt, ...) \
> drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
> -#define DRM_DEBUG_DP(dev, fmt, ...) \
> +#define DRM_DEBUG_DP(fmt, ...) \
> drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
>
> #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-18 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 21:57 [PATCH] drm/print: Fix DRM_DEBUG_DP macro Lyude Paul
2018-07-18 23:07 ` Rodrigo Vivi [this message]
2018-07-18 23:08 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718230705.GD2146@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.