All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 1/2] mtd: rawnand: better name for the controller structure
Date: Thu, 19 Jul 2018 00:02:28 +0200	[thread overview]
Message-ID: <20180719000228.65e3c477@xps13> (raw)
In-Reply-To: <20180718235845.4131d653@bbrezillon>

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Wed, 18 Jul 2018
23:58:45 +0200:

> On Wed, 18 Jul 2018 23:50:55 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >  
> >  /**
> > - * struct nand_hw_control - Control structure for hardware controller (e.g ECC generator) shared among independent devices
> > + * struct nand_controller - Control structure for hardware controller  
> 
> Hm, the description is weird. How about "NAND controller object" or
> "Structure used to describe a NAND controller"
> 
> Other than this detail, it looks all good to me.

That's right I don't like it neither. I just removed the "e.g ECC
generator" which was wrong but it deserves a better definition. I'll
stick to "Structure used to describe a NAND controller" which is clear
enough for me.

I'll fix when applying.

Thanks,
Miquèl

  reply	other threads:[~2018-07-18 22:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 21:50 [PATCH v2 0/2] Changes in the internal raw NAND API Miquel Raynal
2018-07-18 21:50 ` [PATCH v2 1/2] mtd: rawnand: better name for the controller structure Miquel Raynal
2018-07-18 21:58   ` Boris Brezillon
2018-07-18 22:02     ` Miquel Raynal [this message]
2018-07-18 21:50 ` [PATCH v2 2/2] mtd: rawnand: add hooks that may be called during nand_scan() Miquel Raynal
2018-07-18 22:26   ` Boris Brezillon
2018-07-18 22:42   ` Boris Brezillon
2018-07-18 22:46     ` Boris Brezillon
2018-07-18 22:56       ` Miquel Raynal
2018-07-18 22:55     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719000228.65e3c477@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.