From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: make subop helpers return unsigned values
Date: Thu, 19 Jul 2018 00:43:35 +0200 [thread overview]
Message-ID: <20180719004335.3f92a927@bbrezillon> (raw)
In-Reply-To: <20180719004211.4829aa8a@xps13>
On Thu, 19 Jul 2018 00:42:58 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@bootlin.com> wrote on Thu, 19 Jul 2018
> 00:31:34 +0200:
>
> > On Thu, 19 Jul 2018 00:09:12 +0200
> > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > > A report from Colin Ian King pointed a CoverityScan issue where error
> > > values on these helpers where not checked in the drivers. These
> > > helpers can error out only in case of a software bug in driver code,
> > > not because of a runtime/hardware error. Hence, let's WARN_ON() in this
> > > case and return 0 which is harmless anyway.
> > >
> > > Fixes: 8878b126df76 ("mtd: nand: add ->exec_op() implementation")
> > > Cc: stable@vger.kernel.org
> >
> > Is it really worth backporting this patch? I mean, the bug does not
> > exist, it's just a potential problem that can only arise when
> > drivers/core are buggy, which AFAICT is not the case yet :-).
>
> Ok, I'll remove the Cc: stable tag but I guess I can keep the Fixes
> one.
Sure.
next prev parent reply other threads:[~2018-07-18 22:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 22:09 [PATCH v2] mtd: rawnand: make subop helpers return unsigned values Miquel Raynal
2018-07-18 22:31 ` Boris Brezillon
2018-07-18 22:42 ` Miquel Raynal
2018-07-18 22:43 ` Boris Brezillon [this message]
2018-07-19 21:12 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719004335.3f92a927@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.