All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Keerthy <j-keerthy@ti.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	t-kristo@ti.com, linux-rtc@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	johan@kernel.org
Subject: Re: [PATCH v4 1/4] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec
Date: Thu, 19 Jul 2018 12:23:36 +0200	[thread overview]
Message-ID: <20180719102336.GA19245@localhost> (raw)
In-Reply-To: <1531372060-10532-2-git-send-email-j-keerthy@ti.com>

On Thu, Jul 12, 2018 at 10:37:37AM +0530, Keerthy wrote:
> Cut down the shutdown time from 2 seconds to 1 sec. In case of roll
> over try again.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>

> @@ -435,17 +435,23 @@ static void omap_rtc_power_off(void)

> +	/* set alarm one second from now */
>  	omap_rtc_read_time_raw(rtc, &tm);
> +	seconds = tm.tm_sec;
>  	bcd2tm(&tm);
>  	rtc_tm_to_time(&tm, &now);
> -	rtc_time_to_tm(now + 2, &tm);
> +	rtc_time_to_tm(now + 1, &tm);

One more thing, the comment before final mdelay as well as that delay
itself also needs to be updated to reflect this change.

Thanks,
Johan

  parent reply	other threads:[~2018-07-19 10:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  5:07 [PATCH v4 0/4] rtc: OMAP: Add support for rtc-only mode Keerthy
2018-07-12  5:07 ` Keerthy
2018-07-12  5:07 ` [PATCH v4 1/4] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec Keerthy
2018-07-12  5:07   ` Keerthy
2018-07-19 10:02   ` Johan Hovold
2018-07-19 11:53     ` Keerthy
2018-07-19 11:53       ` Keerthy
2018-07-19 12:22       ` Keerthy
2018-07-19 12:22         ` Keerthy
2018-07-19 12:36         ` Johan Hovold
2018-07-19 12:46           ` Keerthy
2018-07-19 12:46             ` Keerthy
2018-07-20 10:33             ` Keerthy
2018-07-20 10:33               ` Keerthy
2018-07-20 11:03               ` Johan Hovold
2018-07-19 10:23   ` Johan Hovold [this message]
2018-07-12  5:07 ` [PATCH v4 2/4] rtc: OMAP: Add support for rtc-only mode Keerthy
2018-07-12  5:07   ` Keerthy
2018-07-19 10:29   ` Johan Hovold
2018-07-12  5:07 ` [PATCH v4 3/4] rtc: omap: use of_device_is_system_power_controller function Keerthy
2018-07-12  5:07   ` Keerthy
2018-07-19 10:34   ` Johan Hovold
2018-07-12  5:07 ` [PATCH v4 4/4] rtc: interface: Add power_off_program to rtc_class_ops Keerthy
2018-07-12  5:07   ` Keerthy
2018-07-19 10:40   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719102336.GA19245@localhost \
    --to=johan@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.