From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Thu, 19 Jul 2018 10:33:55 +0000 Subject: Re: [PATCH v2 1/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Message-Id: <20180719103355.GC424@jagdpanzerIV> List-Id: References: <20180718093002.4596-1-tzimmermann@suse.de> <20180718093002.4596-2-tzimmermann@suse.de> <20180719085303.mkxu7i7zl4suybcz@pathway.suse.cz> <20180719100526.GB424@jagdpanzerIV> <48b38f83-f3cf-943d-bd31-ab2e1bd29d0a@suse.de> In-Reply-To: <48b38f83-f3cf-943d-bd31-ab2e1bd29d0a@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Zimmermann Cc: Petr Mladek , linux-fbdev@vger.kernel.org, Sergey Senozhatsky , b.zolnierkie@samsung.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, hdegoede@redhat.com, dri-devel@lists.freedesktop.org, akpm@linux-foundation.org Hi, On (07/19/18 12:20), Thomas Zimmermann wrote: > Am 19.07.2018 um 12:05 schrieb Sergey Senozhatsky: > > On (07/19/18 10:53), Petr Mladek wrote: > >> Hmm, this approach is racy if there are other users > >> saving/setting/restoring ignore_console_lock_warning in parallel. > >> I mean that this works only when the entire safe/set/restore > >> operation is nested or sequential. > > > > Good point! > > > > However, I tend to think that we don't need to care about it > > that much. Having a counter to permit nesting would probably be > > better, but, like you said, it's unlikely that we will see any > > problems with ignore_console_lock_warning anyway. So we can keep > > it simple [IOW - the way it is]. > > I just sent a new patch set based on atomic_t Ah, just saw the new version. > and TBH it's easier to use that this version. I only had to introduce > the save-state variable in the caller because I couldn't do inc/dec. No objections, if it makes your life easier. Thanks. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: [PATCH v2 1/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Date: Thu, 19 Jul 2018 19:33:55 +0900 Message-ID: <20180719103355.GC424@jagdpanzerIV> References: <20180718093002.4596-1-tzimmermann@suse.de> <20180718093002.4596-2-tzimmermann@suse.de> <20180719085303.mkxu7i7zl4suybcz@pathway.suse.cz> <20180719100526.GB424@jagdpanzerIV> <48b38f83-f3cf-943d-bd31-ab2e1bd29d0a@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B7086E354 for ; Thu, 19 Jul 2018 10:34:00 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id v13-v6so3446942pgr.10 for ; Thu, 19 Jul 2018 03:34:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <48b38f83-f3cf-943d-bd31-ab2e1bd29d0a@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: Petr Mladek , linux-fbdev@vger.kernel.org, Sergey Senozhatsky , b.zolnierkie@samsung.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, hdegoede@redhat.com, dri-devel@lists.freedesktop.org, akpm@linux-foundation.org List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAoMDcvMTkvMTggMTI6MjApLCBUaG9tYXMgWmltbWVybWFubiB3cm90ZToKPiBBbSAx OS4wNy4yMDE4IHVtIDEyOjA1IHNjaHJpZWIgU2VyZ2V5IFNlbm96aGF0c2t5Ogo+ID4gT24gKDA3 LzE5LzE4IDEwOjUzKSwgUGV0ciBNbGFkZWsgd3JvdGU6Cj4gPj4gSG1tLCB0aGlzIGFwcHJvYWNo IGlzIHJhY3kgaWYgdGhlcmUgYXJlIG90aGVyIHVzZXJzCj4gPj4gc2F2aW5nL3NldHRpbmcvcmVz dG9yaW5nIGlnbm9yZV9jb25zb2xlX2xvY2tfd2FybmluZyBpbiBwYXJhbGxlbC4KPiA+PiBJIG1l YW4gdGhhdCB0aGlzIHdvcmtzIG9ubHkgd2hlbiB0aGUgZW50aXJlIHNhZmUvc2V0L3Jlc3RvcmUK PiA+PiBvcGVyYXRpb24gaXMgbmVzdGVkIG9yIHNlcXVlbnRpYWwuCj4gPiAKPiA+IEdvb2QgcG9p bnQhCj4gPiAKPiA+IEhvd2V2ZXIsIEkgdGVuZCB0byB0aGluayB0aGF0IHdlIGRvbid0IG5lZWQg dG8gY2FyZSBhYm91dCBpdAo+ID4gdGhhdCBtdWNoLiBIYXZpbmcgYSBjb3VudGVyIHRvIHBlcm1p dCBuZXN0aW5nIHdvdWxkIHByb2JhYmx5IGJlCj4gPiBiZXR0ZXIsIGJ1dCwgbGlrZSB5b3Ugc2Fp ZCwgaXQncyB1bmxpa2VseSB0aGF0IHdlIHdpbGwgc2VlIGFueQo+ID4gcHJvYmxlbXMgd2l0aCBp Z25vcmVfY29uc29sZV9sb2NrX3dhcm5pbmcgYW55d2F5LiBTbyB3ZSBjYW4ga2VlcAo+ID4gaXQg c2ltcGxlIFtJT1cgLSB0aGUgd2F5IGl0IGlzXS4KPiAKPiBJIGp1c3Qgc2VudCBhIG5ldyBwYXRj aCBzZXQgYmFzZWQgb24gYXRvbWljX3QKCkFoLCBqdXN0IHNhdyB0aGUgbmV3IHZlcnNpb24uCgo+ IGFuZCBUQkggaXQncyBlYXNpZXIgdG8gdXNlIHRoYXQgdGhpcyB2ZXJzaW9uLiBJIG9ubHkgaGFk IHRvIGludHJvZHVjZQo+IHRoZSBzYXZlLXN0YXRlIHZhcmlhYmxlIGluIHRoZSBjYWxsZXIgYmVj YXVzZSBJIGNvdWxkbid0IGRvIGluYy9kZWMuCgpObyBvYmplY3Rpb25zLCBpZiBpdCBtYWtlcyB5 b3VyIGxpZmUgZWFzaWVyLgpUaGFua3MuCgoJLXNzCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=