All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] lib: Factor out is_supported() && Add tst_supported_fs for shell
Date: Thu, 19 Jul 2018 14:27:37 +0200	[thread overview]
Message-ID: <20180719122737.GA19082@rei> (raw)
In-Reply-To: <1531985470-25203-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi!
> +	printf("Usage: tst_supported_fs [fs_type]\n");
> +	printf("   If a specified fs_type is supported, return 1\n");
> +	printf("   If a specified fs_type isn't supported, return 0\n");

Also this is a bit confusing since in shell 0 == true, hence it would be
a bit better to return !tst_fs_is_supported(argv[1]);

-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2018-07-19 12:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11  8:55 [LTP] [PATCH] zram/zram_lib.sh: Check fielsystem support more throughly Xiao Yang
2018-07-18 12:46 ` Cyril Hrubis
2018-07-19  7:31   ` [LTP] [PATCH v2 1/2] lib: Factor out is_supported() && Add tst_supported_fs for shell Xiao Yang
2018-07-19  7:31     ` [LTP] [PATCH v2 2/2] zram/zram_lib.sh: Apply " Xiao Yang
2018-07-19 12:27       ` Cyril Hrubis
2018-07-19 12:21     ` [LTP] [PATCH v2 1/2] lib: Factor out is_supported() && Add " Cyril Hrubis
2018-07-20 10:40       ` [LTP] [PATCH v3 1/2] lib: Factor out is_supported() && Add tst_supported_fs Xiao Yang
2018-07-20 10:40         ` [LTP] [PATCH v3 2/2] zram/zram_lib.sh: Apply tst_supported_fs for shell Xiao Yang
2018-07-23 14:52         ` [LTP] [PATCH v3 1/2] lib: Factor out is_supported() && Add tst_supported_fs Cyril Hrubis
2018-07-19 12:27     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719122737.GA19082@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.