All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] Testing statx syscall
Date: Thu, 19 Jul 2018 14:58:50 +0200	[thread overview]
Message-ID: <20180719125850.GA21609@rei> (raw)
In-Reply-To: <5b980260fcaeb195f7228851a197d7fa.squirrel@pike.zilogic.com>

Hi!
> >> Also, since only ext4 supports these attribute flags for now, we have
> >> used
> >> that alone in our test case.
> >
> > Okay then, if it's supported only by ext4 then we should go with that
> > for now, but we should make sure that mkfs.ext4 is present and that the
> > kernel supports ext4. We do have a functions for that in the C test
> > library.
> >
> >> Also we have used script because we don't have any equivalent for
> >> tune2fs
> >> and e4crypt.
> >
> > Looking closer, the tune2fs writes some bytes to the device, indeed that
> > is something we do not want to replicate in our tests. But we can call
> > the binary easily from the C test as well.
> >
> We are unable to understand this part, Can you help us with this please??

I was just trying to say that we can execute tune2fs from the C
testacase as well. Have a look at how we use tst_run_cmd() in the
syscalls/quotactl/quotactl01.c.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2018-07-19 12:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 13:41 [LTP] [PATCH v2] Testing statx syscall tarun
2018-07-18 12:22 ` Cyril Hrubis
2018-07-19  8:11   ` vaishnavi.d
2018-07-19  9:17     ` Cyril Hrubis
2018-07-19 12:51       ` vaishnavi.d
2018-07-19 12:58         ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719125850.GA21609@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.