From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 5/5] net: add MTD support to eth_platform_get_mac_address() Date: Thu, 19 Jul 2018 17:01:38 +0200 Message-ID: <20180719150138.GC9119@lunn.ch> References: <20180718161035.7005-1-brgl@bgdev.pl> <20180718161035.7005-6-brgl@bgdev.pl> <20180718164737.GE12477@lunn.ch> <20180718170352.GF12477@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , Russell King , Grygorii Strashko , "David S . Miller" , Srinivas Kandagatla , Lukas Wunner , Rob Herring , Florian Fainelli , Dan Carpenter , Ivan Khoronzhuk , David Lechner , Greg Kroah-Hartman , Linux ARM , Linux Kernel Mailing List , linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski List-Id: linux-omap@vger.kernel.org On Thu, Jul 19, 2018 at 10:14:29AM +0200, Bartosz Golaszewski wrote: > 2018-07-18 19:03 GMT+02:00 Andrew Lunn : > >> >> +#ifdef CONFIG_MTD > >> >> + /* NOTE: this should go away as soon as MTD gets nvmem support. */ > >> >> + if (!addr) { > >> >> + struct mtd_info *mtd; > >> >> + int rv; > >> >> + > >> >> + mtd = get_mtd_device_nm("MAC-Address"); > >> > > >> > In order for this to go away, you need to keep backwards > >> > compatibility. When using nvmem, you look for a cell called > >> > "mac-address". Here you are looking for "MAC-Address". That is going > >> > to make backwards compatibility harder. How do you plan to do it? > >> > > >> > Andrew > >> > >> I'm trying to adjust to already existing users. The only user of > >> get_mtd_device_nm() who calls it to read the MAC address registers a > >> partition called "MAC-Address". We can't change it since it's visible > >> from user space. In the future we'd just have to have a list of > >> supported string that we'd use to do the nvmem lookup. > > > > Why not have the nvmem cell called "MAC-Address"? When you add nvmem > > support to MTD, i assume you are going to map each MTD partition to an > > nvmem cell? > > Because all existing users of nvmem use "mac-address" as the name of > this cell already. I guess we will need to live with both in this > particular function. So i'm not convinced this last patch is making things better. I would prefer if it was dropped for the moment. Wait until MTD via nvmem is actually implemented and there is a concrete concept of how a MAC address would be looked up without having lots of ugly code. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Thu, 19 Jul 2018 17:01:38 +0200 Subject: [PATCH 5/5] net: add MTD support to eth_platform_get_mac_address() In-Reply-To: References: <20180718161035.7005-1-brgl@bgdev.pl> <20180718161035.7005-6-brgl@bgdev.pl> <20180718164737.GE12477@lunn.ch> <20180718170352.GF12477@lunn.ch> Message-ID: <20180719150138.GC9119@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jul 19, 2018 at 10:14:29AM +0200, Bartosz Golaszewski wrote: > 2018-07-18 19:03 GMT+02:00 Andrew Lunn : > >> >> +#ifdef CONFIG_MTD > >> >> + /* NOTE: this should go away as soon as MTD gets nvmem support. */ > >> >> + if (!addr) { > >> >> + struct mtd_info *mtd; > >> >> + int rv; > >> >> + > >> >> + mtd = get_mtd_device_nm("MAC-Address"); > >> > > >> > In order for this to go away, you need to keep backwards > >> > compatibility. When using nvmem, you look for a cell called > >> > "mac-address". Here you are looking for "MAC-Address". That is going > >> > to make backwards compatibility harder. How do you plan to do it? > >> > > >> > Andrew > >> > >> I'm trying to adjust to already existing users. The only user of > >> get_mtd_device_nm() who calls it to read the MAC address registers a > >> partition called "MAC-Address". We can't change it since it's visible > >> from user space. In the future we'd just have to have a list of > >> supported string that we'd use to do the nvmem lookup. > > > > Why not have the nvmem cell called "MAC-Address"? When you add nvmem > > support to MTD, i assume you are going to map each MTD partition to an > > nvmem cell? > > Because all existing users of nvmem use "mac-address" as the name of > this cell already. I guess we will need to live with both in this > particular function. So i'm not convinced this last patch is making things better. I would prefer if it was dropped for the moment. Wait until MTD via nvmem is actually implemented and there is a concrete concept of how a MAC address would be looked up without having lots of ugly code. Andrew