All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/3] lib: Add tst_crypto and tst_netlink libs
Date: Thu, 19 Jul 2018 17:11:55 +0200	[thread overview]
Message-ID: <20180719151155.GB24467@rei> (raw)
In-Reply-To: <20180705145635.27244-1-rpalethorpe@suse.com>

Hi!
> +void tst_crypto_open(struct tst_crypto_session *ses)
> +{
> +	TEST(socket(AF_NETLINK, SOCK_DGRAM, NETLINK_CRYPTO));
> +	if (TEST_RETURN < 0 && TEST_ERRNO == EPROTONOSUPPORT) {
> +		tst_brk(TCONF | TTERRNO, "NETLINK_CRYPTO is probably disabled");
> +	} else if (TEST_RETURN < 0) {
> +		tst_brk(TBROK | TTERRNO,
> +			"socket(AF_NETLINK, SOCK_DGRAM, NETLINK_CRYPTO)");
> +	}

I got rid of this else branch, since we call tst_brk() in the first if
it's not needed at all, and pushed both patches, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2018-07-19 15:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 14:56 [LTP] [PATCH v3 1/3] lib: Add tst_crypto and tst_netlink libs Richard Palethorpe
2018-07-05 14:56 ` [LTP] [PATCH v3 2/3] Add pcrypt_aead01 CVE-2017-18075 Richard Palethorpe
2018-07-05 14:56 ` [LTP] [PATCH v3 3/3] Add Doxygen configuration Richard Palethorpe
2018-07-18 12:30   ` Cyril Hrubis
2018-07-18 13:15     ` Richard Palethorpe
2018-07-18 14:54       ` Cyril Hrubis
2018-07-19 13:37         ` Richard Palethorpe
2018-07-19 13:44           ` Cyril Hrubis
2018-07-19 15:11 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719151155.GB24467@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.