From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vakul Garg Subject: [net-next v4 2/3] net/tls: Remove redundant variable assignments and wakeup Date: Thu, 19 Jul 2018 21:29:30 +0530 Message-ID: <20180719155931.21497-3-vakul.garg@nxp.com> References: <20180719155931.21497-1-vakul.garg@nxp.com> Mime-Version: 1.0 Content-Type: text/plain Cc: borisp@mellanox.com, aviadye@mellanox.com, davejwatson@fb.com, davem@davemloft.net, Vakul Garg To: netdev@vger.kernel.org Return-path: Received: from mail-db5eur01on0048.outbound.protection.outlook.com ([104.47.2.48]:44704 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726574AbeGSLWn (ORCPT ); Thu, 19 Jul 2018 07:22:43 -0400 In-Reply-To: <20180719155931.21497-1-vakul.garg@nxp.com> Sender: netdev-owner@vger.kernel.org List-ID: In function decrypt_skb_update(), the assignment to tls receive context variable 'decrypted' is redundant as the same is being done in function tls_sw_recvmsg() after calling decrypt_skb_update(). Also calling callback function to wakeup processes sleeping on socket data availability is useless as decrypt_skb_update() is invoked from user processes only. This patch cleans these up. Signed-off-by: Vakul Garg --- net/tls/tls_sw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index a58661c624ec..e62f288fda31 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -659,7 +659,6 @@ static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb, struct scatterlist *sgout, bool *zc) { struct tls_context *tls_ctx = tls_get_ctx(sk); - struct tls_sw_context_rx *ctx = tls_sw_ctx_rx(tls_ctx); struct strp_msg *rxm = strp_msg(skb); int err = 0; @@ -679,8 +678,6 @@ static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb, rxm->offset += tls_ctx->rx.prepend_size; rxm->full_len -= tls_ctx->rx.overhead_size; tls_advance_record_sn(sk, &tls_ctx->rx); - ctx->decrypted = true; - ctx->saved_data_ready(sk); return err; } -- 2.13.6